You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/08/20 11:52:52 UTC
[PR] Use database default schema in encrypt predicate tokens [shardingsphere]
menghaoranss opened a new pull request, #39533:
URL: https://github.com/apache/shardingsphere/pull/39533
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database default schema in encrypt predicate tokens [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39533:
URL: https://github.com/apache/shardingsphere/pull/39533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database default schema in encrypt predicate tokens [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39533:
URL: https://github.com/apache/shardingsphere/pull/39533#issuecomment-5366917864
```markdown
### Result
**Review Result: Mergeable**
The patch correctly delegates default-schema resolution to `ShardingSphereDatabase` while preserving explicit-schema precedence across direct and delegated predicate-rewrite flows.
### Evidence
- [`EncryptPredicateValueTokenGenerator`](https://github.com/apache/shardingsphere/blob/887389081685e1fec435248473198f14d6e1f4d3/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/predicate/EncryptPredicateValueTokenGenerator.java#L72-L86) uses the database-owned default schema only when the statement lacks an explicit schema.
- The resolved schema continues to reach cipher, assisted-query, and LIKE-query encryption branches.
- [`ShardingSphereDatabase#getDefaultSchemaName`](https://github.com/apache/shardingsphere/blob/887389081685e1fec435248473198f14d6e1f4d3/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabase.java#L303-L315) owns protocol normalization and canonical metadata casing.
- Exact-head verification passed: 2 tests, 0 failures, 0 errors; Maven exit code 0.
### Coverage
- Reviewed head: `887389081685e1fec435248473198f14d6e1f4d3`
- Base and merge-base: `65e298aaeea19adb13a0d7ef8b0a56afd38771e9`
- Both authoritative GitHub files matched the local triple-dot scope and were reviewed.
- Reviewed the predicate-encryption default-schema cluster, including direct and insert-select delegation, schema precedence, metadata ownership, high-frequency-path impact, downstream encryptors, and tests.
- Completed root-cause, blast-radius/contracts, tests/runtime, and convergence passes with no findings or unresolved gaps.
- This is a code-scope result only; CI was not reviewed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org