You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2007/08/06 12:35:04 UTC
DO NOT REPLY [Bug 43041] New: - [PATCH] AFP Renderer - output resolution control
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43041>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43041
Summary: [PATCH] AFP Renderer - output resolution control
Product: Fop
Version: 1.0dev
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: dev@cumiskey.com
* Introduced a a new configuration element
<renderer-resolution>240</renderer-resolution> which is a child of <renderer
mime="application/x-afp"> which allows you to configure the output resolution of
the AFP renderer - I guess other renderers could follow this scheme if they wish
to provide this feature.
* For every class that was touched in the process of adding this new feature, I
have done my best to fix any checkstyle problems (except for violations such as
number of arguments in method > 7 etc). This should make it easier for the
patch reviewer to check I have not introduced any additional checkstyle problems
(only removed them).
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43041] - [PATCH] AFP Renderer - output resolution control
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43041>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43041
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20601|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-08-07 06:34 -------
Created an attachment (id=20612)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20612&action=view)
patch file
This patch supersedes the previous one. I discovered a subversion merge
problem on AFPRenderer.java which is now fixed.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43041] - [PATCH] AFP Renderer - output resolution control
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43041>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43041
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
------- Additional Comments From jeremias@apache.org 2007-10-04 06:44 -------
I've got a question for those who use AFP: Adrian introduced a
renderer-resolution setting. All the other renderers use target-resolution [1].
Since the AFP renderer's default resolution is 240dpi instead of 72 dpi like for
the other renderers. Switching to target-resolution would decrease the output
quality for those who use the AFP renderer at its default settings. But
introducing renderer-resolution adds a third resolution setting which could lead
to confusion. Should we perhaps let each renderer try to give the user agent its
default target resolution?
Opinions? Ideas?
[1] http://xmlgraphics.apache.org/fop/0.94/configuration.html#general-elements
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43041] - [PATCH] AFP Renderer - output resolution control
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43041>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43041
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From jeremias@apache.org 2007-10-05 02:06 -------
Patch applied with modification:
Bugfix: SVGs were rendered in the wrong size when the target-resolution and the
renderer-resolution differ.
http://svn.apache.org/viewvc?rev=582131&view=rev
Adrian, thanks for the patch! I know I once asked you to install Checkstyle and
you took that to heart, but I'd be grateful if you wouldn't do too much
Checkstyle cleanup as part of a patch. It makes it difficult to spot the actual
modifications in all the differences.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43041] - [PATCH] AFP Renderer - output resolution control
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43041>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43041
------- Additional Comments From dev@cumiskey.com 2007-08-06 03:36 -------
Created an attachment (id=20601)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20601&action=view)
patch file
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43041] - [PATCH] AFP Renderer - output resolution control
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43041>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43041
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
------- Additional Comments From jeremias@apache.org 2007-10-04 07:15 -------
Never mind my previous question. Looks like there was already a discussion:
http://marc.info/?l=fop-dev&m=118597659210348&w=2
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.