You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2020/12/05 15:25:20 UTC
[GitHub] [james-project] chibenwa opened a new pull request #273: [ADR] Enhance existing ADRs
chibenwa opened a new pull request #273:
URL: https://github.com/apache/james-project/pull/273
I have been doing a bit of archeology...
- Update the status if needed
- Indicate whether it had been implemented or not
- Link the JIRA ticket (and thus the PRs as they should be references in the JIRA)
- Link the pull request discussing the very ADR
- If possible, link mailing list discussions
Globally, we should try to link better sources of information together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r537968720
##########
File path: src/adr/0039-distributed-blob-garbage-collector.md
##########
@@ -58,6 +60,10 @@ store the blob for. This can make some components harder to implement as we will
Since we will not build a distributed task scheduler. To increment the `reference generation` and launch periodically a
`garbage collection iteration`, the scheduling will be done by an external scheduler (cron job, kubernetes cronjob ...)
which will call a webadmin endpoint to launch this task periodically.
+
+## References
+
+
Review comment:
> And probably the PR creating this ADR?
Which is? Sorry, I did not find it!
(At least not on the apache repo)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r537192104
##########
File path: src/adr/0026-removing-configured-additional-mailboxListeners.md
##########
@@ -6,6 +6,8 @@ Date: 2020-04-03
Accepted (lazy consensus)
+Not implemented yet.
Review comment:
as it's superceded by ADR 35 (and not 34, please fix the line below), is this comment really necessary?
##########
File path: src/adr/0039-distributed-blob-garbage-collector.md
##########
@@ -58,6 +60,10 @@ store the blob for. This can make some components harder to implement as we will
Since we will not build a distributed task scheduler. To increment the `reference generation` and launch periodically a
`garbage collection iteration`, the scheduling will be done by an external scheduler (cron job, kubernetes cronjob ...)
which will call a webadmin endpoint to launch this task periodically.
+
+## References
+
+
Review comment:
empty references?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r538125414
##########
File path: src/adr/0039-distributed-blob-garbage-collector.md
##########
@@ -58,6 +60,10 @@ store the blob for. This can make some components harder to implement as we will
Since we will not build a distributed task scheduler. To increment the `reference generation` and launch periodically a
`garbage collection iteration`, the scheduling will be done by an external scheduler (cron job, kubernetes cronjob ...)
which will call a webadmin endpoint to launch this task periodically.
+
+## References
+
+
Review comment:
https://github.com/linagora/james-project/pull/3122
probably a mistake to not have put it on the Apache repo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r537564622
##########
File path: src/adr/0039-distributed-blob-garbage-collector.md
##########
@@ -58,6 +60,10 @@ store the blob for. This can make some components harder to implement as we will
Since we will not build a distributed task scheduler. To increment the `reference generation` and launch periodically a
`garbage collection iteration`, the scheduling will be done by an external scheduler (cron job, kubernetes cronjob ...)
which will call a webadmin endpoint to launch this task periodically.
+
+## References
+
+
Review comment:
https://issues.apache.org/jira/browse/JAMES-3150 ?
And probably the PR creating this ADR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r537968720
##########
File path: src/adr/0039-distributed-blob-garbage-collector.md
##########
@@ -58,6 +60,10 @@ store the blob for. This can make some components harder to implement as we will
Since we will not build a distributed task scheduler. To increment the `reference generation` and launch periodically a
`garbage collection iteration`, the scheduling will be done by an external scheduler (cron job, kubernetes cronjob ...)
which will call a webadmin endpoint to launch this task periodically.
+
+## References
+
+
Review comment:
> And probably the PR creating this ADR?
Which is? Sorry, I did not find it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r537204201
##########
File path: src/adr/0039-distributed-blob-garbage-collector.md
##########
@@ -58,6 +60,10 @@ store the blob for. This can make some components harder to implement as we will
Since we will not build a distributed task scheduler. To increment the `reference generation` and launch periodically a
`garbage collection iteration`, the scheduling will be done by an external scheduler (cron job, kubernetes cronjob ...)
which will call a webadmin endpoint to launch this task periodically.
+
+## References
+
+
Review comment:
Likely I found nothing!
Maybe implied actors @remk @rouazana could be helping here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #273:
URL: https://github.com/apache/james-project/pull/273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r537204473
##########
File path: src/adr/0026-removing-configured-additional-mailboxListeners.md
##########
@@ -6,6 +6,8 @@ Date: 2020-04-03
Accepted (lazy consensus)
+Not implemented yet.
Review comment:
> is this comment really necessary?
Yes, better be more clear than not enough!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #273:
URL: https://github.com/apache/james-project/pull/273#issuecomment-739563354
thanks a lot for these updates !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #273: [ADR] Enhance existing ADRs
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #273:
URL: https://github.com/apache/james-project/pull/273#issuecomment-744216848
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org