[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7277: Throw NoSuchIcebergTableException instead of ValidationException in G…

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #7277:
URL: https://github.com/apache/iceberg/pull/7277#discussion_r1169138556


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -194,6 +195,24 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
     }
   }
 
+  /**
+   * Validate the Glue table is Iceberg table by checking its parameters. If the table properties
+   * check does not pass, for Iceberg it is equivalent to not having a table in the catalog. We
+   * throw a {@link NoSuchIcebergTableException} in that case.
+   *
+   * @param table glue table
+   * @param fullName full table name for logging
+   * @throws NoSuchIcebergTableException if the table is not an Iceberg table
+   */
+  static void checkIfTableIsIceberg(Table table, String fullName) {

Review Comment:
   Nonblocking nit: can we rename this to `validateIsIcebergTable`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org