You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/04 21:25:07 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4075: Remove
stale test RealtimeTableDataManagerTest
Jackie-Jiang commented on issue #4075: Remove stale test RealtimeTableDataManagerTest
URL: https://github.com/apache/incubator-pinot/pull/4075#issuecomment-480069601
> If I understand right, this test is covering mutable segment's ability to add new rows and serving queries out of it. That aspedct is not covered by RealtimeClusterIntegrationTest
As long as I see, this test does not even add new rows into the data manager, and does not have any assertions. It's just a piece of legacy code left over and does not reflect the data set. I don't think it is worth to be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org