[jira] [Commented] (SAMZA-1128) Remove dependency of debounce timer from the CoordinationUtils

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016507#comment-16016507 ] 

ASF GitHub Bot commented on SAMZA-1128:
---------------------------------------

GitHub user navina opened a pull request:

    https://github.com/apache/samza/pull/195

    SAMZA-1128 : Remove dependency of debounce timer from the CoordinationUtils

    This patch addresses the following:
    * Removes CoordinationUtils#getBarrier, BarrierForVersionUpgrade interface
    * Renamed ZkBarrierForVersionUpgrade to ZkBarrier and introduces a listener ZkBarrierListener
    * Simplified the ZkBarrier class and its integration test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navina/samza SAMZA-1128

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit 2b40ff2a269b982a6704b206a8aad8408ec0c48b
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-15T19:11:29Z

    Removing getBarrier from CoordinationUtils

commit d68c7abfa97e3b45073a29fa091b398c013f11f1
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-16T00:06:59Z

    Renamed waitForBarrier to joinBarrier; timeout to long; Introduced barrier listener and state; Removed debounce timer from ZkBarrier; getEphemeralPath removed from ZkUtils

commit 1fededa79f7367d59e1a05ef9a77543a13e37ed0
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-16T23:14:56Z

    Fixing typos

commit 212f00cd9c97af533210f96898104f42d049e29b
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-17T02:56:18Z

    Barrier Listener works. Timeout test doesn't

commit 4360d1a88c7099474130ae18370781e870959997
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-17T22:11:39Z

    Fixed unit tests and timeout handling

commit b73204a10bf25407bae802f2a2134b052a4bc31b
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T00:23:24Z

    StateChange handler was failing with class cast exception

commit 10f56c0a5bed62191e8caf7727e1dfb3978e4a85
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T06:24:46Z

    Added BarrierKeyBuilder

commit 3a323adcad16d513b3b131526235d4caed9bd97a
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T06:38:42Z

    Added some documentation

commit bbb310cf33da8ee223d32a1beb9e5d5ee65458df
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T06:42:15Z

    Renamed TestZkBarrierForVersionUpgrade and made some variable name refactoring

commit f33e1860cc51cd816ee45b195dcf8e80bc3cbe9a
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T17:25:48Z

    Fixing docs and checkstyle

commit 7e8760356e51db77c1c5af1d3d3cee36e5f3c88f
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T18:14:45Z

    Moved BarrierState enum to Barrier Class

commit 96d795ebd6d3b91f0c6fe301b373e6fbbb502824
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T18:17:57Z

    Removed barrier interface

commit 32cb11206b3f9a1b35b3e383a4f78c0e668aef8f
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-18T21:21:41Z

    Adding more docs

----


> Remove dependency of debounce timer from the CoordinationUtils
> --------------------------------------------------------------
>
>                 Key: SAMZA-1128
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1128
>             Project: Samza
>          Issue Type: Sub-task
>    Affects Versions: 0.13.0
>            Reporter: Boris Shkolnik
>            Assignee: Navina Ramesh
>            Priority: Blocker
>             Fix For: 0.13.0
>
>
> ZkBarrierForVersionUpgrade is tightly coupled with the _ZkJobCoordinator_ implementation. Needs to be refactored.
> Some of the things to clean up :
> * Remove dependency of debounce timer from the _CoordinationUtils_ api



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)