You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by fm...@apache.org on 2010/04/08 10:05:20 UTC

svn commit: r931827 - in /felix/trunk/webconsole/src/main: java/org/apache/felix/webconsole/internal/core/ native2ascii/OSGI-INF/l10n/ resources/OSGI-INF/l10n/ resources/res/ui/ resources/templates/

Author: fmeschbe
Date: Thu Apr  8 08:05:20 2010
New Revision: 931827

URL: http://svn.apache.org/viewvc?rev=931827&view=rev
Log:
FELIX-2261 Display using bundles along with links to the bundle page

Modified:
    felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/ServicesServlet.java
    felix/trunk/webconsole/src/main/native2ascii/OSGI-INF/l10n/bundle_de.properties
    felix/trunk/webconsole/src/main/resources/OSGI-INF/l10n/bundle.properties
    felix/trunk/webconsole/src/main/resources/res/ui/services.js
    felix/trunk/webconsole/src/main/resources/templates/services.html

Modified: felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/ServicesServlet.java
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/ServicesServlet.java?rev=931827&r1=931826&r2=931827&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/ServicesServlet.java (original)
+++ felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/ServicesServlet.java Thu Apr  8 08:05:20 2010
@@ -422,7 +422,7 @@ public class ServicesServlet extends Sim
         jw.key( "bundleVersion" );
         jw.value( Util.getHeaderValue( bundle, Constants.BUNDLE_VERSION ) );
         jw.key( "bundleSymbolicName" );
-        jw.value( Util.getHeaderValue( bundle, Constants.BUNDLE_SYMBOLICNAME ) );
+        jw.value( bundle.getSymbolicName() );
     }
 
 

Modified: felix/trunk/webconsole/src/main/native2ascii/OSGI-INF/l10n/bundle_de.properties
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/native2ascii/OSGI-INF/l10n/bundle_de.properties?rev=931827&r1=931826&r2=931827&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/native2ascii/OSGI-INF/l10n/bundle_de.properties [UTF-8] (original)
+++ felix/trunk/webconsole/src/main/native2ascii/OSGI-INF/l10n/bundle_de.properties [UTF-8] Thu Apr  8 08:05:20 2010
@@ -73,6 +73,7 @@ services.details.hide=Verstecke Details
 services.details.tip=Details
 services.statusline=Dienst Information: total {0} Dienst(e).
 services.caption=Dienste
+services.usingBundles=Nutzende Bundles
 
 # Log plugin
 log.pluginTitle=Log Service

Modified: felix/trunk/webconsole/src/main/resources/OSGI-INF/l10n/bundle.properties
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/resources/OSGI-INF/l10n/bundle.properties?rev=931827&r1=931826&r2=931827&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/resources/OSGI-INF/l10n/bundle.properties (original)
+++ felix/trunk/webconsole/src/main/resources/OSGI-INF/l10n/bundle.properties Thu Apr  8 08:05:20 2010
@@ -74,6 +74,7 @@ services.details.hide=Hide Details
 services.details.tip=Details
 services.statusline=Services information: {0} service(s) in total.
 services.caption=Services
+services.usingBundles=Using Bundles
 
 # Log plugin
 log.pluginTitle=Log Service

Modified: felix/trunk/webconsole/src/main/resources/res/ui/services.js
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/resources/res/ui/services.js?rev=931827&r1=931826&r2=931827&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/resources/res/ui/services.js (original)
+++ felix/trunk/webconsole/src/main/resources/res/ui/services.js Thu Apr  8 08:05:20 2010
@@ -108,8 +108,17 @@ function renderDetails(data) {
 				unbind('click').click(function() {hideDetails(data.id)});
 		}
 	});
-	if (data.props) 
-		$('#pluginInlineDetails' + data.id).append( renderObjectAsTable(data.props) );
+	var details = "";
+	if (data.props) {
+		details += renderObjectAsTable(data.props);
+	}
+	if (data.usingBundles) {
+	   details += renderUsingBundlesAsTable(data.usingBundles);
+	}
+	if (details) {
+        details = '<table border="0"><tbody>' + details + '</tbody></table>';
+	    $('#pluginInlineDetails' + data.id).append( details );
+    }
 }
 
 function renderObjectAsTable(/* Object*/ details) {
@@ -141,10 +150,27 @@ function renderObjectAsTable(/* Object*/
 		txt = txt + '</td></tr>';
 	}
 
-	if ( txt ) {
-		txt = '<table border="0"><tbody>' + txt + '</tbody></table>';
+	return txt;
+}
+
+function renderUsingBundlesAsTable(/* Object[] */ bundles) {
+	var txt = '';
+
+	for (var idx in bundles) {
+		var bundle = bundles[idx];
+		txt += '<a href="' + bundlePath + '/' + bundle.bundleId + '">'
+		    + bundle.bundleSymbolicName + ' (' + bundle.bundleId + ')' 
+		    + '</a><br/>';
 	}
 
+    if (txt) {
+        txt = '<tr><td class="aligntop" noWrap="true" style="border:0px none">'
+            + i18n.usingBundles
+            + '</td><td class="aligntop" style="border:0px none">'
+            + txt
+            + '</td></tr>';
+    }
+
 	return txt;
 }
 

Modified: felix/trunk/webconsole/src/main/resources/templates/services.html
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/resources/templates/services.html?rev=931827&r1=931826&r2=931827&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/resources/templates/services.html [UTF-8] (original)
+++ felix/trunk/webconsole/src/main/resources/templates/services.html [UTF-8] Thu Apr  8 08:05:20 2010
@@ -6,7 +6,8 @@ var i18n = {
 	back : "${back}",
 	detailsHide : "${services.details.hide}",
 	detailsTip : "${services.details.tip}",
-	statline : "${services.statusline}"
+	statline : "${services.statusline}",
+	usingBundles : "${services.usingBundles}"
 }
 
 // data