You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/07 08:44:53 UTC
[GitHub] zentol commented on a change in pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores only being effective whe…
zentol commented on a change in pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208146029
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/description/TextElement.java
##########
@@ -53,6 +55,16 @@ public static TextElement text(String text) {
return new TextElement(text, Collections.emptyList());
}
+ /**
+ * Tries to format the text as code.
+ *
+ * @return text element with applied formatting
+ */
+ public TextElement formatAsCode() {
Review comment:
At the very least I would add a static `code(String)` method to make it more readable. i.e.
```
public static TextElement code(String text) {
return new TextElement(text, TextStyle.CODE, Collections.emptyList());
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services