[jira] Commented: (HARMONY-3015) [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs

["Sian January (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487766 ] 

Sian January commented on HARMONY-3015:
---------------------------------------

Hi Alexei,

Thanks for looking at this patch.  I just wanted to explain the clone() fixes.  The methods are fixed so that super.clone() is always called.  This means that the clone() method on Object is always called, so the cloned object will always be of the correct type.  If LDAPCertStoreParameters.clone() just returns a new LDAPCertStoreParameters then any subtypes that call super.clone() will return an object of the wrong type.  It's also explained here -  http://findbugs.sourceforge.net/bugDescriptions.html#CN_IDIOM_NO_SUPER_CALL in the FindBugs documentation.

The fixes were not generated automatically - I wrote them manually based on a report produced by FindBugs.  I can't see anything obvious in the patch that needs to be filtered out but I'm happy to discuss anything else you are concerned about.

Thanks,

Sian

> [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3015
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3015
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: exclusionFilter.xml.patch, exclusionFilter.xml.patch2, security.patch, security.patch2
>
>
> I am attaching a patch containing fixes for minor issues in the security module, and also a second patch for the exclusionFilter.xml file found in standard/tools/FindBugs to exclude false positives in the same module.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.