[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6340: make subquery in SubqueryRouteTest work well

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#discussion_r454092992



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java
##########
@@ -108,15 +106,6 @@
      * @return subquery where segment collection.
      */
     public Collection<WhereSegment> getSubqueryWhereSegments() {
-        Collection<WhereSegment> subqueryWhereSegments = new ArrayList<>();

Review comment:
       Hi, Sorry for the late feedback.
   Do you think it is possible to move this function to `SelectStatementContext` referring to [#6319](https://github.com/apache/shardingsphere/pull/6319/files).
   Basically, `xxxStatement` is designed as a POJO object, and we put more logic coding into `xxxStatementContext` for `rewriting`.

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java
##########
@@ -108,15 +106,6 @@
      * @return subquery where segment collection.
      */
     public Collection<WhereSegment> getSubqueryWhereSegments() {
-        Collection<WhereSegment> subqueryWhereSegments = new ArrayList<>();

Review comment:
       Besides, I presume #6319 finished part of your work, so my suggestion is you'd better give it check, and if possible, a coding merging and optimizing is welcomed. :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org