[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #931: Add residual evaluation for MR reader

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #931: Add residual evaluation for MR reader
URL: https://github.com/apache/incubator-iceberg/pull/931#discussion_r409749438
 
 

 ##########
 File path: mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
 ##########
 @@ -259,18 +255,6 @@ public ConfigBuilder skipResidualFiltering() {
     return splits;
   }
 
-  private static void checkResiduals(CombinedScanTask task) {
-    task.files().forEach(fileScanTask -> {
 
 Review comment:
   Seems like we should still do this check for Pig and Hive as we don't have residual evaluators for these. If `IcebergInputFormat.ConfigBuilder#skipResidualFiltering` is `true` then this check should be there for Pig and Hive rows

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org