svn commit: r1862436 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java

[ti...@apache.org]

Author: tilman
Date: Tue Jul  2 16:02:10 2019
New Revision: 1862436

URL: http://svn.apache.org/viewvc?rev=1862436&view=rev
Log:
PDFBOX-4589: warn about overwriting only in the short constructor

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java?rev=1862436&r1=1862435&r2=1862436&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java Tue Jul  2 16:02:10 2019
@@ -81,6 +81,8 @@ public final class PDPageContentStream e
   
     private static final Log LOG = LogFactory.getLog(PDPageContentStream.class);
 
+    private boolean sourcePageHadContents = false;
+
     /**
      * Create a new PDPage content stream. This constructor overwrites all existing content streams
      * of this page.
@@ -92,6 +94,10 @@ public final class PDPageContentStream e
     public PDPageContentStream(PDDocument document, PDPage sourcePage) throws IOException
     {
         this(document, sourcePage, AppendMode.OVERWRITE, true, false);
+        if (sourcePageHadContents)
+        {
+            LOG.warn("You are overwriting an existing content, you should use the append mode");
+        }
     }
 
     /**
@@ -198,10 +204,7 @@ public final class PDPageContentStream e
         }
         else
         {
-            if (sourcePage.hasContents())
-            {
-                LOG.warn("You are overwriting an existing content, you should use the append mode");
-            }
+            sourcePageHadContents = sourcePage.hasContents();
             sourcePage.setContents(stream);
         }