You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2015/06/01 22:24:42 UTC
Re: Review Request 31071: SENTRY-622: Update SentryService for
import/export feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31071/#review85683
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java
<https://reviews.apache.org/r/31071/#comment137387>
typo: poicy => policy?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
<https://reviews.apache.org/r/31071/#comment137389>
These utility functions should not be duplicated as much as possible and should stay in utility classes or SentryStore.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
<https://reviews.apache.org/r/31071/#comment137895>
Same comment about utility functions consolidation as above.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
<https://reviews.apache.org/r/31071/#comment137388>
same typo "Poicy"
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
<https://reviews.apache.org/r/31071/#comment137928>
Again, utility function to serialize TPrivilege, probably should remain in SentryStore or some other utility class?
- Sravya Tirukkovalur
On May 20, 2015, 1:34 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31071/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 1:34 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update SentryService for import/export feature
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 7a9f0df
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java 44681ca
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 30792f3
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 31071: SENTRY-622: Update SentryService for
import/export feature
Posted by Colin Ma <ju...@intel.com>.
> On June 1, 2015, 8:24 p.m., Sravya Tirukkovalur wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java, line 896
> > <https://reviews.apache.org/r/31071/diff/4/?file=964676#file964676line896>
> >
> > These utility functions should not be duplicated as much as possible and should stay in utility classes or SentryStore.
Thanks for the comments, create a new utility class SentryServiceUtil for these utility functions.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31071/#review85683
-----------------------------------------------------------
On June 2, 2015, 8:32 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31071/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 8:32 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update SentryService for import/export feature
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 05cbfb6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java c3c1907
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 30792f3
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>