[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #3900: Refactor in preparation for the ORCRecordReader

[GitBox <gi...@apache.org>]

sunithabeeram commented on a change in pull request #3900: Refactor in preparation for the ORCRecordReader
URL: https://github.com/apache/incubator-pinot/pull/3900#discussion_r262275558
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReaderFactory.java
 ##########
 @@ -35,6 +40,22 @@ public static RecordReader getRecordReader(SegmentGeneratorConfig segmentGenerat
 
     Schema schema = segmentGeneratorConfig.getSchema();
     FileFormat fileFormat = segmentGeneratorConfig.getFormat();
+    String recordReaderPath = segmentGeneratorConfig.getRecordReaderPath();
+
+    // Allow for instantiation general record readers from a record reader path passed into segment generator config
+    // If this is set, this will override the file format
+    if (recordReaderPath != null) {
+      if (fileFormat != null) {
+        // We currently have default file format set to AVRO inside segment generator config,
+        // do not want to break this behavior for clients.
+        LOGGER.warn("Using recordReaderPath {} to read segment, ignoring fileformat {}",
 
 Review comment:
   Will this get logged everytime the record reader path is set? If so, it can be confusing to the users. It might be good to work the fall back at this layer perhaps? (ie, remove filling in the default from the config and have logic to use the default here?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org