You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/01 15:24:46 UTC
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12332
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
IMPALA-5861: fix RowsRead for zero-slot table scan
Testing:
Added regression test based on JIRA.
Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
2 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/12332/1
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3764/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 16:19:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 20:37:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1959/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Feb 2019 15:49:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test
File testdata/workloads/functional-query/queries/QueryTest/scanners.test:
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test@139
PS6, Line 139: 1
> The long result could be avoided with "select avg(1) from alltypessmall", w
I'm concerned that this could result in losing coverage if the planner gets smart enough to realise that avg(1) is always 1.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 00:02:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12332
to look at the new patch set (#4).
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
IMPALA-5861: fix RowsRead for zero-slot table scan
Testing:
Added regression test based on JIRA.
Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
---
M testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
M testdata/workloads/functional-query/queries/QueryTest/scanners.test
2 files changed, 125 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/12332/4
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12332
to look at the new patch set (#3).
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
IMPALA-5861: fix RowsRead for zero-slot table scan
Testing:
Added regression test based on JIRA.
Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
---
M testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
M testdata/workloads/functional-query/queries/QueryTest/scanners.test
2 files changed, 125 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/12332/3
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test
File testdata/workloads/functional-query/queries/QueryTest/scanners.test:
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test@139
PS6, Line 139: 1
> I'm concerned that this could result in losing coverage if the planner gets
What if we omit the RESULTS section? The test seems to work fine for me.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 12:08:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
IMPALA-5861: fix RowsRead for zero-slot table scan
Testing:
Added regression test based on JIRA and a targeted
test for all HDFS file formats.
Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Reviewed-on: http://gerrit.cloudera.org:8080/12332
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
M testdata/workloads/functional-query/queries/QueryTest/scanners.test
3 files changed, 126 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2024/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:31:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test
File testdata/workloads/functional-query/queries/QueryTest/scanners.test:
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test@139
PS6, Line 139: 1
> What if we omit the RESULTS section? The test seems to work fine for me.
We could do that - I'm not opposed. Generally I like to keep the RESULTS section even if it's not directly related to the test to confirm that the query is actually doing what we think it is.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 18:29:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test
File testdata/workloads/functional-query/queries/QueryTest/scanners.test:
http://gerrit.cloudera.org:8080/#/c/12332/6/testdata/workloads/functional-query/queries/QueryTest/scanners.test@139
PS6, Line 139: 1
The long result could be avoided with "select avg(1) from alltypessmall", which should also materialize zero slots.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 16:22:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 2:
(1 comment)
The modification looks good, I only have a comment about the query used in the test.
http://gerrit.cloudera.org:8080/#/c/12332/2/testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
File testdata/workloads/functional-query/queries/QueryTest/mixed-format.test:
http://gerrit.cloudera.org:8080/#/c/12332/2/testdata/workloads/functional-query/queries/QueryTest/mixed-format.test@31
PS2, Line 31: select count(*) from functional.alltypesmixedformat
I was confused when I looked at this test, because it has a count(*) that is optimized for Parquet and it shouldn't read any rows. Also, the modification in hdfs-parquet-scanner.cc doesn't touch this optimized path.
This test works because this query doesn't use the optimized path, maybe because the table has different formats for its partitions.
To me it would be cleaner to use 'select 1 from functional_parquet.alltypes', or explain the behavior in the comment.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 10:56:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 10:16:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12332
to look at the new patch set (#6).
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
IMPALA-5861: fix RowsRead for zero-slot table scan
Testing:
Added regression test based on JIRA and a targeted
test for all HDFS file formats.
Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
M testdata/workloads/functional-query/queries/QueryTest/scanners.test
3 files changed, 126 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/12332/6
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 16:19:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2026/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:38:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12332/2/testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
File testdata/workloads/functional-query/queries/QueryTest/mixed-format.test:
http://gerrit.cloudera.org:8080/#/c/12332/2/testdata/workloads/functional-query/queries/QueryTest/mixed-format.test@31
PS2, Line 31: select count(*) from functional.alltypesmixedformat
> That's a good idea. I think it's worth keeping this since it's the query t
* the problem
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 21:56:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12332/2/testdata/workloads/functional-query/queries/QueryTest/mixed-format.test
File testdata/workloads/functional-query/queries/QueryTest/mixed-format.test:
http://gerrit.cloudera.org:8080/#/c/12332/2/testdata/workloads/functional-query/queries/QueryTest/mixed-format.test@31
PS2, Line 31: select count(*) from functional.alltypesmixedformat
> I was confused when I looked at this test, because it has a count(*) that i
That's a good idea. I think it's worth keeping this since it's the query that the probably was originally noticed on, but I added a variant of your idea to scanners.test, which is run with all file formats so we can make sure the same bug doesn't exist in other places.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 21:55:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5861: fix RowsRead for zero-slot table scan
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12332 )
Change subject: IMPALA-5861: fix RowsRead for zero-slot table scan
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2040/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a927c6a4f0b8055608cb7a5e2b550a1610cef89
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 13:58:20 +0000
Gerrit-HasComments: No