You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/10 15:34:21 UTC
[GitHub] [spark] cloud-fan opened a new pull request, #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
cloud-fan opened a new pull request, #36498:
URL: https://github.com/apache/spark/pull/36498
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/35204 . https://github.com/apache/spark/pull/35204 introduced a potential regression: it removes the "location" table property from `V1Table` if the table is not external. The intention was to avoid putting the LOCATION clause for managed tables in `ShowCreateTableExec`. However, if we use the v2 DESCRIBE TABLE command by default in the future, this will bring a behavior change and v2 DESCRIBE TABLE command won't print the table location for managed tables.
This PR fixes this regression by using a different idea to fix the SHOW CREATE TABLE issue:
1. introduce a new reserved table property `is_managed_location`, to indicate that the location is managed by the catalog, not user given.
2. `ShowCreateTableExec` only generates the LOCATION clause if the "location" property is present and is not managed.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
4. If you fix a bug, you can clarify why it is a bug.
-->
avoid a potential regression
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
existing tests. We can add a test when we use v2 DESCRIBE TABLE command by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869879838
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3288,7 +3288,15 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
throw QueryParsingErrors.cannotCleanReservedTablePropertyError(
PROP_EXTERNAL, ctx, "please use CREATE EXTERNAL TABLE")
case (PROP_EXTERNAL, _) => false
- case _ => true
+ // It's safe to set whatever table comment, so we don't make it a reserved table property.
+ case (PROP_COMMENT, _) => true
+ case (k, _) =>
Review Comment:
We may add more reserved properties in the future that the suggestion can only be `please remove it from the TBLPROPERTIES list`, so I wrote the code this way to ease the work of adding new reserved properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869879838
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3288,7 +3288,15 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
throw QueryParsingErrors.cannotCleanReservedTablePropertyError(
PROP_EXTERNAL, ctx, "please use CREATE EXTERNAL TABLE")
case (PROP_EXTERNAL, _) => false
- case _ => true
+ // It's safe to set whatever table comment, so we don't make it a reserved table property.
+ case (PROP_COMMENT, _) => true
+ case (k, _) =>
Review Comment:
We may add more reserved properties in the future that do not have alternatives such as `CREATE EXTERNAL TABLE`, so I wrote the code this way to ease the work of adding new reserved properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
huaxingao commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869865835
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3288,7 +3288,15 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
throw QueryParsingErrors.cannotCleanReservedTablePropertyError(
PROP_EXTERNAL, ctx, "please use CREATE EXTERNAL TABLE")
case (PROP_EXTERNAL, _) => false
- case _ => true
+ // It's safe to set whatever table comment, so we don't make it a reserved table property.
+ case (PROP_COMMENT, _) => true
+ case (k, _) =>
Review Comment:
That's where I got confused too. If we want to keep the code above to issue a better error message, why not adding something in parallel such as
```
case (PROP_IS_MANAGED_LOCATION, _) if !legacyOn =>
throw QueryParsingErrors.cannotCleanReservedTablePropertyError(
PROP_IS_MANAGED_LOCATION, ctx, "xxxxxx")
case (PROP_IS_MANAGED_LOCATION, _) =>
false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869847600
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -47,6 +47,12 @@ public interface TableCatalog extends CatalogPlugin {
*/
String PROP_LOCATION = "location";
+ /**
+ * A reserved property to indicate that the table location is managed, not user-specified.
+ * If this property is "true", SHOW CREATE TABLE will not generate the LOCATION clause.
+ */
+ String PROP_IS_MANAGED_LOCATION = "is_managed_location";
Review Comment:
I don't think we will use `TableCatalog` to support views. I'm adding this new property as I think this is the most precise way. People can create EXTERNAL table without location, or create MANAGED TABLE with location. What we care in SHOW CREATE TABLE is if the location is generated by the catalog or not, instead of the table type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #36498:
URL: https://github.com/apache/spark/pull/36498#issuecomment-1122554247
cc @Peng-Lei @huaxingao @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #36498:
URL: https://github.com/apache/spark/pull/36498#issuecomment-1123250739
thanks for the review, merging to master/3.3!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
URL: https://github.com/apache/spark/pull/36498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869823873
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -47,6 +47,12 @@ public interface TableCatalog extends CatalogPlugin {
*/
String PROP_LOCATION = "location";
+ /**
+ * A reserved property to indicate that the table location is managed, not user-specified.
+ * If this property is "true", SHOW CREATE TABLE will not generate the LOCATION clause.
+ */
+ String PROP_IS_MANAGED_LOCATION = "is_managed_location";
Review Comment:
nit :
actually, we can add a reserved property named `PROP_TABLE_TYPE`, because type include `EXTERNAL` `MANAGED` `VIEW` that also can control the different behaviors when `TYPE == MANAGED`. And `PROP_TABLE_TYPE` sounds more generic, may be we can add more type in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869848173
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3288,7 +3288,15 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
throw QueryParsingErrors.cannotCleanReservedTablePropertyError(
PROP_EXTERNAL, ctx, "please use CREATE EXTERNAL TABLE")
case (PROP_EXTERNAL, _) => false
- case _ => true
+ // It's safe to set whatever table comment, so we don't make it a reserved table property.
+ case (PROP_COMMENT, _) => true
+ case (k, _) =>
Review Comment:
We need the code above to throw errors with a better error message, which gives suggestions like `please use CREATE EXTERNAL TABLE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869803912
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3288,7 +3288,15 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
throw QueryParsingErrors.cannotCleanReservedTablePropertyError(
PROP_EXTERNAL, ctx, "please use CREATE EXTERNAL TABLE")
case (PROP_EXTERNAL, _) => false
- case _ => true
+ // It's safe to set whatever table comment, so we don't make it a reserved table property.
+ case (PROP_COMMENT, _) => true
+ case (k, _) =>
Review Comment:
I think it is duplicate with case before. Just leave code you added is simple and clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869847600
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -47,6 +47,12 @@ public interface TableCatalog extends CatalogPlugin {
*/
String PROP_LOCATION = "location";
+ /**
+ * A reserved property to indicate that the table location is managed, not user-specified.
+ * If this property is "true", SHOW CREATE TABLE will not generate the LOCATION clause.
+ */
+ String PROP_IS_MANAGED_LOCATION = "is_managed_location";
Review Comment:
I don't think we will use `TableCatalog` to support views. I'm adding this new property as I think this is the most precise way. People can create EXTERNAL table without location, or create MANAGED TABLE with location. What we care in SHOW CREATE TABLE is if the location is managed or not, instead of the table type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a diff in pull request #36498: [SPARK-37878][SQL][FOLLOWUP] V1Table should always carry the "location" property
Posted by GitBox <gi...@apache.org>.
huaxingao commented on code in PR #36498:
URL: https://github.com/apache/spark/pull/36498#discussion_r869884252
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3288,7 +3288,15 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
throw QueryParsingErrors.cannotCleanReservedTablePropertyError(
PROP_EXTERNAL, ctx, "please use CREATE EXTERNAL TABLE")
case (PROP_EXTERNAL, _) => false
- case _ => true
+ // It's safe to set whatever table comment, so we don't make it a reserved table property.
+ case (PROP_COMMENT, _) => true
+ case (k, _) =>
Review Comment:
Got it. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org