You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/06/03 11:46:07 UTC

[GitHub] [geode] alb3rtobr opened a new pull request #6552: GEODE-7967: User Guide - gfsh start locator - reformat oversize table

alb3rtobr opened a new pull request #6552:
URL: https://github.com/apache/geode/pull/6552


   Fix format issues in the start command page of the user guide.
   `start locator` and `start server` command tables have been transformed from html to markdown format. Also, some html tags have been substituted by markdown tags.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] davebarnes97 merged pull request #6552: GEODE-7967: User Guide - gfsh start locator - reformat oversize table

Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #6552:
URL: https://github.com/apache/geode/pull/6552


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] davebarnes97 merged pull request #6552: GEODE-7967: User Guide - gfsh start locator - reformat oversize table

Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #6552:
URL: https://github.com/apache/geode/pull/6552


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] alb3rtobr commented on pull request #6552: GEODE-7967: User Guide - gfsh start locator - reformat oversize table

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6552:
URL: https://github.com/apache/geode/pull/6552#issuecomment-863925811


   > Very nice - thanks!
   > I would like to request a change to be repeated in four locations, where an option name wraps between the double-hyphen and the name. The remedy is to replace the two hyphens with a pair of non-breaking hyphens. I've attached a git diff that shows where the changes are needed.
   > [PR6552-diff.txt](https://github.com/apache/geode/files/6671802/PR6552-diff.txt)
   
   Thanks for the fix @davebarnes97 , I didnt know about these non-breaking hyphens


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] davebarnes97 commented on pull request #6552: GEODE-7967: User Guide - gfsh start locator - reformat oversize table

Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on pull request #6552:
URL: https://github.com/apache/geode/pull/6552#issuecomment-854856669


   Thanks for your contribution, @alb3rtobr. Just a note to let you know that due to schedule pressures, it may be a few days before I'm able to complete my review. Apologies for any inconvenience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org