You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/31 01:11:27 UTC

[GitHub] [skywalking] hanahmily commented on pull request #7495: Banyandb storage plugin

hanahmily commented on pull request #7495:
URL: https://github.com/apache/skywalking/pull/7495#issuecomment-908817587


   It makes sense to me. Maybe the Banyandb repo is a proper place to hold
   client Java codes and build artifacts.
   
   On Tue, Aug 31, 2021 at 9:07 AM 吴晟 Wu Sheng ***@***.***>
   wrote:
   
   > @kezhenxu94 <https://github.com/kezhenxu94> Does GitHub provide a
   > snapshot based maven repo? If so, we could keep what we did for agent test,
   > which is, We could create a banyandb-java-client repo, and hosts all Java
   > driver related codes, and get a dev maven repo too. In the main repo, we
   > are going to need snapshot dependency only.
   >
   > After that, we could keep this PR to the master branch(don't need to sync
   > codes anymore), every time this PR gets update, the test could run directly.
   >
   > @lujiajing1126 <https://github.com/lujiajing1126> @hanahmily
   > <https://github.com/hanahmily> What do you think about this, rather than
   > maintaining another branch?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/skywalking/pull/7495#issuecomment-908815760>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAO6UWMJC4KD3Z3C7PHTBADT7QTMPANCNFSM5CN7LBTA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org