[GitHub] [spark] leanken commented on a change in pull request #29389: [SPARK-32573][SQL] Eliminate Anti Join when BuildSide is Empty

[GitBox <gi...@apache.org>]

leanken commented on a change in pull request #29389:
URL: https://github.com/apache/spark/pull/29389#discussion_r467525605



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -125,7 +125,7 @@ private[execution] object HashedRelation {
  *  [number of keys]
  *  [size of key] [size of value] [key bytes] [bytes for value]
  */
-private[joins] class UnsafeHashedRelation(
+class UnsafeHashedRelation(

Review comment:
       Ah. this is historical code. A question, should we consider the same when
   LongHashedRelation.keys.isEmpty
   UnsafeHashedRelation.keys.isEmpty
   equalTo EmptyHashedRelation
   if it does, we need this private[joins] to be removed. I am not quite sure. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org