You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/13 15:20:03 UTC
[GitHub] [incubator-eventmesh] keranbingaa opened a new pull request, #2584: [ISSUE #2519]Merge the exception catched statement
keranbingaa opened a new pull request, #2584:
URL: https://github.com/apache/incubator-eventmesh/pull/2584
fix #2519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #2584: [ISSUE #2519]Merge the exception catched statement
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #2584:
URL: https://github.com/apache/incubator-eventmesh/pull/2584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2584: [ISSUE #2519]Merge the exception catched statement
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2584:
URL: https://github.com/apache/incubator-eventmesh/pull/2584#issuecomment-1353289172
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2584](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0fe7e4) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/512728e02a35de991e802ec1a34be14cdb5ae5d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (512728e) will **increase** coverage by `0.45%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2584 +/- ##
============================================
+ Coverage 11.38% 11.83% +0.45%
- Complexity 877 900 +23
============================================
Files 469 476 +7
Lines 27944 27212 -732
Branches 3031 2817 -214
============================================
+ Hits 3181 3221 +40
+ Misses 24478 23703 -775
- Partials 285 288 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | `36.27% <0.00%> (+1.03%)` | :arrow_up: |
| [...che/eventmesh/runtime/boot/AbstractHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RIVFRQU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ventmesh/common/protocol/grpc/protos/Response.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9SZXNwb25zZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ntmesh/runtime/metrics/http/HTTPMetricsServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL21ldHJpY3MvaHR0cC9IVFRQTWV0cmljc1NlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mesh/common/protocol/grpc/protos/BatchMessage.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9CYXRjaE1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mesh/common/protocol/grpc/protos/Subscription.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9TdWJzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tmesh/runtime/metrics/tcp/EventMeshTcpMonitor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL21ldHJpY3MvdGNwL0V2ZW50TWVzaFRjcE1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...esh/common/protocol/grpc/protos/RequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9SZXF1ZXN0SGVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...esh/common/protocol/grpc/protos/SimpleMessage.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9TaW1wbGVNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...esh/common/protocol/http/body/BaseRequestBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvQmFzZVJlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2584/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #2584: [ISSUE #2519]Merge the exception catched statement
Posted by GitBox <gi...@apache.org>.
jonyangx commented on code in PR #2584:
URL: https://github.com/apache/incubator-eventmesh/pull/2584#discussion_r1047996683
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -104,12 +104,9 @@ public static String getLocalAddress() {
//If failed to find,fall back to localhost
final InetAddress localHost = InetAddress.getLocalHost();
return normalizeHostAddress(localHost);
- } catch (SocketException e) {
- LOG.error("socket exception", e);
- } catch (UnknownHostException e) {
- LOG.error("unknown host exception", e);
+ } catch (SocketException | UnknownHostException e) {
+ LOG.error(e.getMessage());
Review Comment:
suggest log error with exception object ,not message.
LOG.error(message,e);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] keranbingaa commented on a diff in pull request #2584: [ISSUE #2519]Merge the exception catched statement
Posted by GitBox <gi...@apache.org>.
keranbingaa commented on code in PR #2584:
URL: https://github.com/apache/incubator-eventmesh/pull/2584#discussion_r1049752456
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -104,12 +104,9 @@ public static String getLocalAddress() {
//If failed to find,fall back to localhost
final InetAddress localHost = InetAddress.getLocalHost();
return normalizeHostAddress(localHost);
- } catch (SocketException e) {
- LOG.error("socket exception", e);
- } catch (UnknownHostException e) {
- LOG.error("unknown host exception", e);
+ } catch (SocketException | UnknownHostException e) {
+ LOG.error(e.getMessage());
Review Comment:
ok，i will modify this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #2584: [ISSUE #2519]Merge the exception catched statement
Posted by GitBox <gi...@apache.org>.
jonyangx commented on code in PR #2584:
URL: https://github.com/apache/incubator-eventmesh/pull/2584#discussion_r1047996683
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -104,12 +104,9 @@ public static String getLocalAddress() {
//If failed to find,fall back to localhost
final InetAddress localHost = InetAddress.getLocalHost();
return normalizeHostAddress(localHost);
- } catch (SocketException e) {
- LOG.error("socket exception", e);
- } catch (UnknownHostException e) {
- LOG.error("unknown host exception", e);
+ } catch (SocketException | UnknownHostException e) {
+ LOG.error(e.getMessage());
Review Comment:
suggest log error with exception object ,not message.
LOG.error(message,e); @keranbingaa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #2584: [ISSUE #2519]Merge the exception catched statement
Posted by GitBox <gi...@apache.org>.
jonyangx commented on code in PR #2584:
URL: https://github.com/apache/incubator-eventmesh/pull/2584#discussion_r1047996683
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -104,12 +104,9 @@ public static String getLocalAddress() {
//If failed to find,fall back to localhost
final InetAddress localHost = InetAddress.getLocalHost();
return normalizeHostAddress(localHost);
- } catch (SocketException e) {
- LOG.error("socket exception", e);
- } catch (UnknownHostException e) {
- LOG.error("unknown host exception", e);
+ } catch (SocketException | UnknownHostException e) {
+ LOG.error(e.getMessage());
Review Comment:
suggest log error with exception object ,not message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org