You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/06/15 19:46:42 UTC
[jira] [Created] (HDFS-3539) fix implicit function declaration in
libhdfs
Colin Patrick McCabe created HDFS-3539:
------------------------------------------
Summary: fix implicit function declaration in libhdfs
Key: HDFS-3539
URL: https://issues.apache.org/jira/browse/HDFS-3539
Project: Hadoop HDFS
Issue Type: Bug
Environment: fix implicit function declaration in libhdfs
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HDFS-3539.001.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414253#comment-13414253 ]
Hudson commented on HDFS-3539:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2469 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2469/])
HDFS-3539. libhdfs code cleanups. Contributed by Colin Patrick McCabe (Revision 1361459)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361459
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_connect.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_dfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_chown.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_init.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_options.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_read.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_write.c
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) libhdfs code cleanups
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Attachment: HDFS-3539.005.patch
* rebase on trunk
* add unrelated unit test change to work around the fact that HADOOP-8584 and HDFS-3606 are not in yet.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HDFS-3539) libhdfs code cleanups
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HDFS-3539.
-------------------------------
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.2-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404662#comment-13404662 ]
Hadoop QA commented on HDFS-3539:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534131/HDFS-3539.003.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2726//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2726//console
This message is automatically generated.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) libhdfs code cleanups
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3539:
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I've committed this and merged to branch-2. Thanks Colin.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414231#comment-13414231 ]
Hudson commented on HDFS-3539:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2488 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2488/])
HDFS-3539. libhdfs code cleanups. Contributed by Colin Patrick McCabe (Revision 1361459)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361459
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_connect.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_dfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_chown.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_init.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_options.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_read.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_write.c
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) libhdfs code cleanups
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Description: Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
Environment: (was: fix implicit function declaration in libhdfs)
Summary: libhdfs code cleanups (was: fix implicit function declaration in libhdfs)
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) fix implicit function declaration in
libhdfs
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Attachment: HDFS-3539.001.patch
fix compiler warning
> fix implicit function declaration in libhdfs
> --------------------------------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Environment: fix implicit function declaration in libhdfs
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414216#comment-13414216 ]
Eli Collins commented on HDFS-3539:
-----------------------------------
+1 lgtm
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) fix implicit function declaration in
libhdfs
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Attachment: HDFS-3539.002.patch
function declaration should not be static.
> fix implicit function declaration in libhdfs
> --------------------------------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Environment: fix implicit function declaration in libhdfs
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414258#comment-13414258 ]
Hudson commented on HDFS-3539:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2534 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2534/])
HDFS-3539. libhdfs code cleanups. Contributed by Colin Patrick McCabe (Revision 1361459)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361459
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_connect.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_dfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_chown.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_init.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_options.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_read.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_write.c
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) fix implicit function declaration in
libhdfs
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Status: Patch Available (was: Open)
> fix implicit function declaration in libhdfs
> --------------------------------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Environment: fix implicit function declaration in libhdfs
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) libhdfs code cleanups
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Attachment: HDFS-3539.003.patch
* libhdfs.h: only include the header files we need. Including extra header files slows down compilation and may complicate matters for library users.
* libhdfs.h: we don't need tTime, a typedef to a type that is itself a typedef, time_t. Just use int64_t, which reflects the fact that HDFS deals with time as a 64-bit number. (Note that time_t is 64 bits on most modern systems, but we shouldn't be relying on that.)
* do not expose the fields of hdfsFile_internal in the header file. Instead, offer accessors to things that might be interesting to library users, like whether a file is open for read, open for write, using direct read, etc.
* set LIBHDFS_VERSION to 1.0.0
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) libhdfs code cleanups
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Attachment: HDFS-3539.006.patch
* include "string.h" rather than "strings.h"
* fix whitespace issue
* put "visible for testing" functions in a separate header
* create hdfs_internal structure type, and use that for hdfsFS. This way, type mismatches will be detected automatically. This also allows forward declaration.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411052#comment-13411052 ]
Hadoop QA commented on HDFS-3539:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535913/HDFS-3539.005.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2778//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2778//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2778//console
This message is automatically generated.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) fix implicit function declaration in
libhdfs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295883#comment-13295883 ]
Hadoop QA commented on HDFS-3539:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532220/HDFS-3539.002.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2657//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2657//console
This message is automatically generated.
> fix implicit function declaration in libhdfs
> --------------------------------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Environment: fix implicit function declaration in libhdfs
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410665#comment-13410665 ]
Hadoop QA commented on HDFS-3539:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535887/HDFS-3539.004.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2775//console
This message is automatically generated.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412501#comment-13412501 ]
Hadoop QA commented on HDFS-3539:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536153/HDFS-3539.006.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2802//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2802//console
This message is automatically generated.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Andy Isaacson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413409#comment-13413409 ]
Andy Isaacson commented on HDFS-3539:
-------------------------------------
LGTM. +1 on .006.patch.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414413#comment-13414413 ]
Hudson commented on HDFS-3539:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1136 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1136/])
HDFS-3539. libhdfs code cleanups. Contributed by Colin Patrick McCabe (Revision 1361459)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361459
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_connect.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_dfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_chown.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_init.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_options.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_read.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_write.c
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3539) libhdfs code cleanups
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3539:
---------------------------------------
Attachment: HDFS-3539.004.patch
* don't change time_t to int64_t (it would be an ABI change)
* remove whitespace change
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Andy Isaacson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411861#comment-13411861 ]
Andy Isaacson commented on HDFS-3539:
-------------------------------------
{code}
+++ hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_init.c
...
+#include <strings.h>
{code}
I think <string.h> is preferred. strings.h was a BSDism IIRC.
(I realize you're just moving code, but let's do the cleanup too.)
{code}
- tSize num_written_bytes = hdfsWrite(lfs, localFile,
- (void*)fileContents,
- strlen(fileContents) + 1);
+ num_written_bytes = hdfsWrite(lfs, localFile, (void*)fileContents,
+ strlen(fileContents) + 1);
{code}
I'd maintain the indent style here; line up strlen with the (.
Writing the NUL terminator of the string out to the file is a little baroque, but I guess it works. Changing the semantics of the code would go beyond cleanups.
I'm not entirely convinced that adding an API {{hdfsFileUsesDirectRead}} that is only used for tests is a good idea; think of the private data members as @VisibleForTest or similar. But I am fine if you think it's a good cleanup.
I don't think the TestNameNodeRecovery.java whitespace cleanup belongs in this patch. If you were already touching that file for a substantive change it would be fine.
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) libhdfs code cleanups
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414359#comment-13414359 ]
Hudson commented on HDFS-3539:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1103 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1103/])
HDFS-3539. libhdfs code cleanups. Contributed by Colin Patrick McCabe (Revision 1361459)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361459
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_connect.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_dfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_chown.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_init.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_options.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_read.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.c
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_test.h
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs_write.c
> libhdfs code cleanups
> ---------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, HDFS-3539.003.patch, HDFS-3539.004.patch, HDFS-3539.005.patch, HDFS-3539.006.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and extraneous includes in libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3539) fix implicit function declaration in
libhdfs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295806#comment-13295806 ]
Hadoop QA commented on HDFS-3539:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532214/HDFS-3539.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javac. The patch appears to cause the build to fail.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2656//console
This message is automatically generated.
> fix implicit function declaration in libhdfs
> --------------------------------------------
>
> Key: HDFS-3539
> URL: https://issues.apache.org/jira/browse/HDFS-3539
> Project: Hadoop HDFS
> Issue Type: Bug
> Environment: fix implicit function declaration in libhdfs
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3539.001.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira