You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2010/08/31 00:47:55 UTC
[jira] Created: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
-------------------------------------------------------------------------
Key: CASSANDRA-1446
URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.7 beta 1
Reporter: Brandon Williams
Assignee: Eric Evans
Fix For: 0.7 beta 2
When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904409#action_12904409 ]
Eric Evans commented on CASSANDRA-1446:
---------------------------------------
cassandra-cli never used the set of arguments from cassandra.in.sh which included (among other things) the heap size. This was on purpose, the memory requirements of the CLI should be negligible, and there is definitely no correlation to the memory needed by the server.
Do you know of a specific problem here? Can you provide any specifics?
> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-1446:
----------------------------------------
Priority: Trivial (was: Major)
> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908538#action_12908538 ]
Hudson commented on CASSANDRA-1446:
-----------------------------------
Integrated in Cassandra #533 (See [https://hudson.apache.org/hudson/job/Cassandra/533/])
> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.6.6, 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904505#action_12904505 ]
Brandon Williams commented on CASSANDRA-1446:
---------------------------------------------
256M works for me, but let's put this in 0.6 too.
> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904504#action_12904504 ]
Eric Evans commented on CASSANDRA-1446:
---------------------------------------
{quote}
The specific problem I'm seeing here is that the user can launch cassandra itself, but doesn't have enough memory to launch cassandra-cli afterwards, and there isn't an intuitive way to change cassandra-cli's heap.
{quote}
Interesting. I would have thought the default max heap size would be something... reasonable, but on my machine it seems to be 987MB (the hell?!).
Anyway, I just checked in a change that sets this to 256MB. I don't know if that's the optimal value but it's considerably less than the almost-a-gig default. The only reason it would ever need to be bigger than say 16MB is to buffer larger responses, and 256MB seems like a gracious plenty for any practical use of our CLI.
{quote}
I see cassandra-cli's script specifically trying to include cassandra.in.sh, though, on second look, it does not appear to be doing anything with it. Maybe we should just remove the cassandra.in.sh cruft.
{quote}
It is using it though, it's using it to setup the classpath; cassandra.in.sh is basically the common code for setting the classpath in all of those scripts.
> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904433#action_12904433 ]
Brandon Williams commented on CASSANDRA-1446:
---------------------------------------------
The specific problem I'm seeing here is that the user can launch cassandra itself, but doesn't have enough memory to launch cassandra-cli afterwards, and there isn't an intuitive way to change cassandra-cli's heap. I see cassandra-cli's script specifically trying to include cassandra.in.sh, though, on second look, it does not appear to be doing anything with it. Maybe we should just remove the cassandra.in.sh cruft.
> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1446) cassandra-cli still relies on
cassandra.in.sh instead of cassandra-env.sh
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans resolved CASSANDRA-1446.
-----------------------------------
Fix Version/s: 0.6.6
Resolution: Fixed
committed new max heap to 0.6 and trunk
> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.6.6, 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well. This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.