You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/19 03:13:40 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4687: fs/partition: Make read_partition_block callable outside ptable

xiaoxiang781216 commented on pull request #4687:
URL: https://github.com/apache/incubator-nuttx/pull/4687#issuecomment-946330543


   > LGTM. Not related to this PR, but shouldn't `parse_ptable_partition` also be declared on `fs/partition/partition.h`? The declaration is currently in `fs/partition/fs_partition.c`, which does not make much sense to me.
   
   Good pointer, update too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org