You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/03/07 02:44:21 UTC
Review Request 18884: During upgrade. migrate decommissioned DN hosts list
to the new format
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18884/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
Bugs: AMBARI-4983
https://issues.apache.org/jira/browse/AMBARI-4983
Repository: ambari
Description
-------
The details of how the notion of a decommissioned DN is stored has changed for 1.5.0. Add support to modify persisted data when Ambari is upgraded to 1.5.0.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 9571eb4
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/18884/diff/
Testing
-------
Thanks,
Sid Wagle
Re: Review Request 18884: During upgrade. migrate decommissioned DN hosts
list to the new format
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18884/#review36815
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On March 11, 2014, 7:53 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18884/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 7:53 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-4983
> https://issues.apache.org/jira/browse/AMBARI-4983
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The details of how the notion of a decommissioned DN is stored has changed for 1.5.0. Add support to modify persisted data when Ambari is upgraded to 1.5.0.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eabaffc
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18884/diff/
>
>
> Testing
> -------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.server.upgrade.UpgradeCatalog150Test
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.173 sec
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 18884: During upgrade. migrate decommissioned DN hosts
list to the new format
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18884/
-----------------------------------------------------------
(Updated March 11, 2014, 5:53 p.m.)
Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
Changes
-------
Incorporated comments.
Bugs: AMBARI-4983
https://issues.apache.org/jira/browse/AMBARI-4983
Repository: ambari
Description
-------
The details of how the notion of a decommissioned DN is stored has changed for 1.5.0. Add support to modify persisted data when Ambari is upgraded to 1.5.0.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eabaffc
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/18884/diff/
Testing
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.server.upgrade.UpgradeCatalog150Test
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.173 sec
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Sid Wagle
Re: Review Request 18884: During upgrade. migrate decommissioned DN hosts
list to the new format
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18884/#review36805
-----------------------------------------------------------
Transactional annotation in unit tests doesn't have sense as class object is not created by Guice and method interceptor won't be called.
Just a note: also it won't be called on private methods even if object created with Guice.
Test is working with detached enities, but I don't see any issues with that, so they can be simply removed.
Other looks good.
- Myroslav Papirkovskyy
On March 7, 2014, 3:44 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18884/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 3:44 a.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-4983
> https://issues.apache.org/jira/browse/AMBARI-4983
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The details of how the notion of a decommissioned DN is stored has changed for 1.5.0. Add support to modify persisted data when Ambari is upgraded to 1.5.0.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 9571eb4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18884/diff/
>
>
> Testing
> -------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.server.upgrade.UpgradeCatalog150Test
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.173 sec
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 18884: During upgrade. migrate decommissioned DN hosts
list to the new format
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18884/
-----------------------------------------------------------
(Updated March 7, 2014, 1:44 a.m.)
Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
Bugs: AMBARI-4983
https://issues.apache.org/jira/browse/AMBARI-4983
Repository: ambari
Description
-------
The details of how the notion of a decommissioned DN is stored has changed for 1.5.0. Add support to modify persisted data when Ambari is upgraded to 1.5.0.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 9571eb4
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/18884/diff/
Testing (updated)
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.server.upgrade.UpgradeCatalog150Test
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.173 sec
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Sid Wagle