You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by 苏仕祥 <sh...@qq.com> on 2019/09/06 08:40:29 UTC
回复： Talk about how to set committer bar
I agree with the rules.
But the question is ,such as rule 3, we may not have effect method to meature how much contributions someone makes.
lulu
------------------ 原始邮件 ------------------
发件人: "zhangliang@apache.org"<zh...@apache.org>;
发送时间: 2019年9月6日(星期五) 上午10:49
收件人: "dev"<de...@shardingsphere.apache.org>;
主题: Re: Talk about how to set committer bar
Ok, we can set the committer bar more dynamic for different stage.
Right now, the rules may include:
1. Contribute codes, contributor may contribute several pull requests.
2. Answer questions and participant discussion on Github and mailing list
actively.
3. Other things for participant and contribute for community, such as talk
about the project in public conf/event, publish articles and so on.
Any thing else?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Justin Mclean <jm...@apache.org> 于2019年9月6日周五 上午10:20写道：
> Hi,
>
> Again each project is different and sets their own committer bar, but I
> wouldn't worry so much about the PR being perfect either, they can always
> be fixed and improved. By setting the quality bar too high people may not
> contribute because they don't think this code is good enough, even when
> it's a good idea that would improved the code base.
>
> Thanks,
> Justin
>
Re: Talk about how to set committer bar
Posted by 苏仕祥 <sh...@qq.com>.
So the contributions someone makes is ambiguous.I just mention that thing.
But whatever,the community will know who makes contributions.
In conclusion,I approve the rules.
---Original---
From: "zhangliang@apache.org"<zhangliang@apache.org>
Date: Fri, Sep 6, 2019 19:54 PM
To: "dev"<dev@shardingsphere.apache.org>;
Subject: Re: Talk about how to set committer bar
Because way of contributions are diversity, so do we really need a clear
rule for voting, or just start to vote if some PPMCs think a contributor
could be prompt as a committer?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
苏仕祥 <shixiangsu@qq.com> 于2019年9月6日周五 下午4:40写道：
> I agree with the rules.
>
>
> But the question is ,such as rule 3, we may not have effect method to
> meature how much contributions someone makes.
>
>
> lulu
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "zhangliang@apache.org"<zhangliang@apache.org>;
> 发送时间: 2019年9月6日(星期五) 上午10:49
> 收件人: "dev"<dev@shardingsphere.apache.org>;
>
> 主题: Re: Talk about how to set committer bar
>
>
>
> Ok, we can set the committer bar more dynamic for different stage.
>
> Right now, the rules may include:
>
> 1. Contribute codes, contributor may contribute several pull requests.
> 2. Answer questions and participant discussion on Github and mailing list
> actively.
> 3. Other things for participant and contribute for community, such as talk
> about the project in public conf/event, publish articles and so on.
>
> Any thing else?
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Justin Mclean <jmclean@apache.org> 于2019年9月6日周五 上午10:20写道：
>
> > Hi,
> >
> > Again each project is different and sets their own committer bar, but I
> > wouldn't worry so much about the PR being perfect either, they can always
> > be fixed and improved. By setting the quality bar too high people may not
> > contribute because they don't think this code is good enough, even when
> > it's a good idea that would improved the code base.
> >
> > Thanks,
> > Justin
> >
Re: Talk about how to set committer bar
Posted by Sheng Wu <wu...@gmail.com>.
Commitments to a community is recognized by humand, ppmc. Really, don't set
a static rules, if the man makes you trusted, then at least invite him as
committer.
Static rule in this part makes contributor feeling like chasing a kpi.
Personal, don't like this.
Sheng
zhangliang@apache.org <zh...@apache.org>于2019年9月6日 周五上午4:54写道：
> Because way of contributions are diversity, so do we really need a clear
> rule for voting, or just start to vote if some PPMCs think a contributor
> could be prompt as a committer?
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> 苏仕祥 <sh...@qq.com> 于2019年9月6日周五 下午4:40写道：
>
> > I agree with the rules.
> >
> >
> > But the question is ,such as rule 3, we may not have effect method to
> > meature how much contributions someone makes.
> >
> >
> > lulu
> >
> >
> > ------------------ 原始邮件 ------------------
> > 发件人: "zhangliang@apache.org"<zh...@apache.org>;
> > 发送时间: 2019年9月6日(星期五) 上午10:49
> > 收件人: "dev"<de...@shardingsphere.apache.org>;
> >
> > 主题: Re: Talk about how to set committer bar
> >
> >
> >
> > Ok, we can set the committer bar more dynamic for different stage.
> >
> > Right now, the rules may include:
> >
> > 1. Contribute codes, contributor may contribute several pull requests.
> > 2. Answer questions and participant discussion on Github and mailing list
> > actively.
> > 3. Other things for participant and contribute for community, such as
> talk
> > about the project in public conf/event, publish articles and so on.
> >
> > Any thing else?
> > ------------------
> >
> > Liang Zhang (John)
> > Apache ShardingSphere & Dubbo
> >
> >
> > Justin Mclean <jm...@apache.org> 于2019年9月6日周五 上午10:20写道：
> >
> > > Hi,
> > >
> > > Again each project is different and sets their own committer bar, but I
> > > wouldn't worry so much about the PR being perfect either, they can
> always
> > > be fixed and improved. By setting the quality bar too high people may
> not
> > > contribute because they don't think this code is good enough, even when
> > > it's a good idea that would improved the code base.
> > >
> > > Thanks,
> > > Justin
> > >
>
--
Sheng Wu
SkyWalking, Shardingsphere and Zipkin
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
Because way of contributions are diversity, so do we really need a clear
rule for voting, or just start to vote if some PPMCs think a contributor
could be prompt as a committer?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
苏仕祥 <sh...@qq.com> 于2019年9月6日周五 下午4:40写道：
> I agree with the rules.
>
>
> But the question is ,such as rule 3, we may not have effect method to
> meature how much contributions someone makes.
>
>
> lulu
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "zhangliang@apache.org"<zh...@apache.org>;
> 发送时间: 2019年9月6日(星期五) 上午10:49
> 收件人: "dev"<de...@shardingsphere.apache.org>;
>
> 主题: Re: Talk about how to set committer bar
>
>
>
> Ok, we can set the committer bar more dynamic for different stage.
>
> Right now, the rules may include:
>
> 1. Contribute codes, contributor may contribute several pull requests.
> 2. Answer questions and participant discussion on Github and mailing list
> actively.
> 3. Other things for participant and contribute for community, such as talk
> about the project in public conf/event, publish articles and so on.
>
> Any thing else?
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Justin Mclean <jm...@apache.org> 于2019年9月6日周五 上午10:20写道：
>
> > Hi,
> >
> > Again each project is different and sets their own committer bar, but I
> > wouldn't worry so much about the PR being perfect either, they can always
> > be fixed and improved. By setting the quality bar too high people may not
> > contribute because they don't think this code is good enough, even when
> > it's a good idea that would improved the code base.
> >
> > Thanks,
> > Justin
> >