You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/28 13:56:04 UTC

[GitHub] [hudi] xccui opened a new pull request, #5461: [MINOR] Fix a NPE for Option

xccui opened a new pull request, #5461:
URL: https://github.com/apache/hudi/pull/5461

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Fix a minor NPE issue when using `Option`.
   
   ## Brief change log
   
   * Remove the default `null` since it will be returned by default
   * Use `Option.ofNullable()` instead of `Option.of()` to avoid NPE
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5461:
URL: https://github.com/apache/hudi/pull/5461#issuecomment-1112384609

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369",
       "triggerID" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 52507c1050969f26f7f70e1cf1c563c6b8573e70 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5461:
URL: https://github.com/apache/hudi/pull/5461#issuecomment-1123887412

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369",
       "triggerID" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0dc4599e879bf4d074a616400ff48f63d35992e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d0dc4599e879bf4d074a616400ff48f63d35992e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 52507c1050969f26f7f70e1cf1c563c6b8573e70 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369) 
   * d0dc4599e879bf4d074a616400ff48f63d35992e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5461:
URL: https://github.com/apache/hudi/pull/5461#issuecomment-1112246564

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 52507c1050969f26f7f70e1cf1c563c6b8573e70 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xccui commented on pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
xccui commented on PR #5461:
URL: https://github.com/apache/hudi/pull/5461#issuecomment-1123834717

   Sure. I'll do it right now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5461:
URL: https://github.com/apache/hudi/pull/5461


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5461:
URL: https://github.com/apache/hudi/pull/5461#issuecomment-1123892675

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369",
       "triggerID" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0dc4599e879bf4d074a616400ff48f63d35992e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8578",
       "triggerID" : "d0dc4599e879bf4d074a616400ff48f63d35992e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 52507c1050969f26f7f70e1cf1c563c6b8573e70 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369) 
   * d0dc4599e879bf4d074a616400ff48f63d35992e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8578) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5461:
URL: https://github.com/apache/hudi/pull/5461#issuecomment-1112250457

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369",
       "triggerID" : "52507c1050969f26f7f70e1cf1c563c6b8573e70",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 52507c1050969f26f7f70e1cf1c563c6b8573e70 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8369) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #5461: [MINOR] Fix a NPE for Option

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5461:
URL: https://github.com/apache/hudi/pull/5461#issuecomment-1123833215

   @xccui : can you rebase w/ latest master. I see some CI failure. guess we fixed the issue for the failure. we should not any issue w/ latest master. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org