You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/09/16 23:20:50 UTC
[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #6026: [TE] Moving the current dashboard server code to a new module
suvodeep-pyne opened a new pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026#issuecomment-696835579
Thanks a lot @vincentchenjl @jihaozh !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026#issuecomment-696835579
Thanks a lot @vincentchenjl @jihaozh !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on a change in pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026#discussion_r491240900
##########
File path: thirdeye/thirdeye-pinot/pom.xml
##########
@@ -361,52 +361,6 @@
<build>
<plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
Review comment:
The shading is moved to the `thirdeye-dashboard`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026#issuecomment-693744923
I think IntelliJ did some magic when moving those files. It is fixing the line separators as per *nix standards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
vincentchenjl commented on a change in pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026#discussion_r491239194
##########
File path: thirdeye/thirdeye-pinot/pom.xml
##########
@@ -361,52 +361,6 @@
<build>
<plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
Review comment:
Per our discussion, we are going to publish shaded JAR and source JAR together. We should only remove this plugin once we have both JAR build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #6026: [TE] Creating a thirdeye-dashboard module to host the dashboard server
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org