You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:07:38 UTC
[GitHub] [beam] qinyeli opened a new pull request #12686: Removing dead code from Interactive Beam.
qinyeli opened a new pull request #12686:
URL: https://github.com/apache/beam/pull/12686
Seems that no one has been referencing PipelineAnalyzer since BEAM-8016.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.21% +0.88%
==========================================
Files 694 1419 +725
Lines 82230 168800 +86570
Branches 9295 9249 -46
==========================================
+ Hits 28228 59441 +31213
- Misses 53579 108936 +55357
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [apache\_beam/runners/direct/direct\_metrics\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X21ldHJpY3NfdGVzdC5weQ==) | `34.42% <0.00%> (ø)` | |
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMl9ncnBjLnB5) | `50.42% <0.00%> (ø)` | |
| [...ache\_beam/runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.61% <0.00%> (ø)` | |
| [.../direct/consumer\_tracking\_pipeline\_visitor\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvY29uc3VtZXJfdHJhY2tpbmdfcGlwZWxpbmVfdmlzaXRvcl90ZXN0LnB5) | `24.73% <0.00%> (ø)` | |
| [apache\_beam/io/gcp/tests/pubsub\_matcher.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL3B1YnN1Yl9tYXRjaGVyLnB5) | `24.70% <0.00%> (ø)` | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `43.24% <0.00%> (ø)` | |
| [apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/pvalue\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcHZhbHVlX3Rlc3QucHk=) | `63.63% <0.00%> (ø)` | |
| ... and [719 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-689955735
Is this something that happens often? Do you know how we can resolve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-691249780
> Is this something that happens often? Do you know how we can resolve this?
I think we sometimes ignore this kind of errors.
Let me add Pablo as the reviewer.
Hi @pabloem, could you please take a look at this PR that cleans up dead code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.21% +0.88%
==========================================
Files 694 1419 +725
Lines 82230 168800 +86570
Branches 9295 9249 -46
==========================================
+ Hits 28228 59441 +31213
- Misses 53579 108936 +55357
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [...e\_beam/runners/dataflow/internal/apiclient\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnRfdGVzdC5weQ==) | `23.65% <0.00%> (ø)` | |
| [apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/io/aws/s3filesystem\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vYXdzL3MzZmlsZXN5c3RlbV90ZXN0LnB5) | `28.98% <0.00%> (ø)` | |
| [...eam/examples/complete/game/leader\_board\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9sZWFkZXJfYm9hcmRfaXRfdGVzdC5weQ==) | `53.33% <0.00%> (ø)` | |
| [apache\_beam/transforms/periodicsequence\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlX3Rlc3QucHk=) | `38.29% <0.00%> (ø)` | |
| [...amples/complete/juliaset/juliaset/juliaset\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvanVsaWFzZXRfdGVzdC5weQ==) | `40.47% <0.00%> (ø)` | |
| [apache\_beam/runners/worker/operations.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3BlcmF0aW9ucy5weQ==) | `26.70% <0.00%> (ø)` | |
| [apache\_beam/internal/http\_client.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW50ZXJuYWwvaHR0cF9jbGllbnQucHk=) | `39.13% <0.00%> (ø)` | |
| ... and [719 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.21% +0.88%
==========================================
Files 694 1419 +725
Lines 82230 168800 +86570
Branches 9295 9249 -46
==========================================
+ Hits 28228 59441 +31213
- Misses 53579 108936 +55357
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [...pets/transforms/elementwise/withtimestamps\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS93aXRodGltZXN0YW1wc190ZXN0LnB5) | `55.55% <0.00%> (ø)` | |
| [...nippets/transforms/aggregation/groupintobatches.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9ncm91cGludG9iYXRjaGVzLnB5) | `37.50% <0.00%> (ø)` | |
| [apache\_beam/dataframe/schemas.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZGF0YWZyYW1lL3NjaGVtYXMucHk=) | `68.00% <0.00%> (ø)` | |
| [apache\_beam/internal/gcp/auth.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL2F1dGgucHk=) | `47.27% <0.00%> (ø)` | |
| [apache\_beam/runners/direct/direct\_metrics\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X21ldHJpY3NfdGVzdC5weQ==) | `34.42% <0.00%> (ø)` | |
| [apache\_beam/typehints/typehints.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHlwZWhpbnRzL3R5cGVoaW50cy5weQ==) | `51.20% <0.00%> (ø)` | |
| [apache\_beam/internal/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/examples/complete/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [719 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-692296995
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-692088106
Thanks @KevinGG @qinyeli ! We can merge as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.18% +0.85%
==========================================
Files 694 1421 +727
Lines 82230 169311 +87081
Branches 9295 9249 -46
==========================================
+ Hits 28228 59569 +31341
- Misses 53579 109319 +55740
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/examples/wordcount\_minimal.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvd29yZGNvdW50X21pbmltYWwucHk=) | `43.33% <0.00%> (ø)` | |
| [...he\_beam/tools/runtime\_type\_check\_microbenchmark.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdG9vbHMvcnVudGltZV90eXBlX2NoZWNrX21pY3JvYmVuY2htYXJrLnB5) | `0.00% <0.00%> (ø)` | |
| [...\_beam/testing/benchmarks/nexmark/queries/query3.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTMucHk=) | `0.00% <0.00%> (ø)` | |
| [apache\_beam/coders/observable\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vY29kZXJzL29ic2VydmFibGVfdGVzdC5weQ==) | `45.16% <0.00%> (ø)` | |
| [...ets/transforms/aggregation/combineglobally\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb21iaW5lZ2xvYmFsbHlfdGVzdC5weQ==) | `65.00% <0.00%> (ø)` | |
| [...ache\_beam/io/external/xlang\_snowflakeio\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwveGxhbmdfc25vd2ZsYWtlaW9faXRfdGVzdC5weQ==) | `40.24% <0.00%> (ø)` | |
| [...e\_beam/examples/complete/game/hourly\_team\_score.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9ob3VybHlfdGVhbV9zY29yZS5weQ==) | `41.46% <0.00%> (ø)` | |
| ... and [721 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.18% +0.85%
==========================================
Files 694 1421 +727
Lines 82230 169311 +87081
Branches 9295 9249 -46
==========================================
+ Hits 28228 59569 +31341
- Misses 53579 109319 +55740
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [...e\_beam/runners/dataflow/internal/apiclient\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnRfdGVzdC5weQ==) | `23.65% <0.00%> (ø)` | |
| [apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/io/aws/s3filesystem\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vYXdzL3MzZmlsZXN5c3RlbV90ZXN0LnB5) | `28.98% <0.00%> (ø)` | |
| [...eam/examples/complete/game/leader\_board\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9sZWFkZXJfYm9hcmRfaXRfdGVzdC5weQ==) | `53.33% <0.00%> (ø)` | |
| [apache\_beam/transforms/periodicsequence\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlX3Rlc3QucHk=) | `38.29% <0.00%> (ø)` | |
| [...amples/complete/juliaset/juliaset/juliaset\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvanVsaWFzZXRfdGVzdC5weQ==) | `40.47% <0.00%> (ø)` | |
| [apache\_beam/runners/worker/operations.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3BlcmF0aW9ucy5weQ==) | `26.70% <0.00%> (ø)` | |
| [apache\_beam/internal/http\_client.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW50ZXJuYWwvaHR0cF9jbGllbnQucHk=) | `39.13% <0.00%> (ø)` | |
| ... and [721 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-683341182
Rerun test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `25.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
===========================================
+ Coverage 34.32% 59.52% +25.19%
===========================================
Files 694 1424 +730
Lines 82230 174728 +92498
Branches 9295 9249 -46
===========================================
+ Hits 28228 104005 +75777
- Misses 53579 70300 +16721
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [apache\_beam/dataframe/frames\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lc190ZXN0LnB5) | `98.85% <0.00%> (ø)` | |
| [...ache\_beam/runners/portability/local\_job\_service.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZS5weQ==) | `81.16% <0.00%> (ø)` | |
| [...he\_beam/io/gcp/datastore/v1new/datastoreio\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9kYXRhc3RvcmVpb190ZXN0LnB5) | `98.80% <0.00%> (ø)` | |
| [...e\_beam/runners/interactive/testing/mock\_ipython.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL21vY2tfaXB5dGhvbi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV90ZXN0LnB5) | `95.12% <0.00%> (ø)` | |
| [apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `92.16% <0.00%> (ø)` | |
| [apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `74.96% <0.00%> (ø)` | |
| [.../examples/streaming\_wordcount\_debugging\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc3RyZWFtaW5nX3dvcmRjb3VudF9kZWJ1Z2dpbmdfaXRfdGVzdC5weQ==) | `55.76% <0.00%> (ø)` | |
| ... and [724 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.21% +0.88%
==========================================
Files 694 1419 +725
Lines 82230 168800 +86570
Branches 9295 9249 -46
==========================================
+ Hits 28228 59441 +31213
- Misses 53579 108936 +55357
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [apache\_beam/typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `22.34% <0.00%> (ø)` | |
| [apache\_beam/testing/datatype\_inference\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdGVzdGluZy9kYXRhdHlwZV9pbmZlcmVuY2VfdGVzdC5weQ==) | `66.21% <0.00%> (ø)` | |
| [apache\_beam/examples/complete/estimate\_pi\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZXN0aW1hdGVfcGlfdGVzdC5weQ==) | `54.54% <0.00%> (ø)` | |
| [...amples/snippets/transforms/elementwise/map\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9tYXBfdGVzdC5weQ==) | `61.76% <0.00%> (ø)` | |
| [apache\_beam/ml/gcp/cloud\_dlp\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vbWwvZ2NwL2Nsb3VkX2RscF90ZXN0LnB5) | `37.33% <0.00%> (ø)` | |
| [...ataflow/dataflow\_exercise\_metrics\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19leGVyY2lzZV9tZXRyaWNzX3BpcGVsaW5lX3Rlc3QucHk=) | `54.83% <0.00%> (ø)` | |
| [...testing/integration/tests/init\_square\_cube\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3Rlc3RzL2luaXRfc3F1YXJlX2N1YmVfdGVzdC5weQ==) | `77.77% <0.00%> (ø)` | |
| [apache\_beam/ml/gcp/naturallanguageml\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vbWwvZ2NwL25hdHVyYWxsYW5ndWFnZW1sX3Rlc3QucHk=) | `40.00% <0.00%> (ø)` | |
| ... and [719 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-691249780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli closed pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli closed pull request #12686:
URL: https://github.com/apache/beam/pull/12686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.21% +0.88%
==========================================
Files 694 1419 +725
Lines 82230 168800 +86570
Branches 9295 9249 -46
==========================================
+ Hits 28228 59441 +31213
- Misses 53579 108936 +55357
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [apache\_beam/portability/api/endpoints\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjJfZ3JwYy5weQ==) | `0.00% <0.00%> (ø)` | |
| [apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==) | `40.83% <0.00%> (ø)` | |
| [apache\_beam/coders/slow\_coders\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfY29kZXJzX3Rlc3QucHk=) | `50.00% <0.00%> (ø)` | |
| [apache\_beam/dataframe/transforms.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZGF0YWZyYW1lL3RyYW5zZm9ybXMucHk=) | `18.06% <0.00%> (ø)` | |
| [apache\_beam/runners/common\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9jb21tb25fdGVzdC5weQ==) | `24.53% <0.00%> (ø)` | |
| [...che\_beam/runners/dataflow/dataflow\_metrics\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzX3Rlc3QucHk=) | `39.70% <0.00%> (ø)` | |
| [apache\_beam/metrics/monitoring\_infos.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vbWV0cmljcy9tb25pdG9yaW5nX2luZm9zLnB5) | `37.28% <0.00%> (ø)` | |
| [...m/testing/benchmarks/chicago\_taxi/trainer/model.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL21vZGVsLnB5) | `0.00% <0.00%> (ø)` | |
| ... and [719 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.18% +0.85%
==========================================
Files 694 1421 +727
Lines 82230 169311 +87081
Branches 9295 9249 -46
==========================================
+ Hits 28228 59569 +31341
- Misses 53579 109319 +55740
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [apache\_beam/io/external/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (ø)` | |
| [apache\_beam/transforms/display\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9kaXNwbGF5X3Rlc3QucHk=) | `27.34% <0.00%> (ø)` | |
| [apache\_beam/coders/row\_coder\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlcl90ZXN0LnB5) | `39.75% <0.00%> (ø)` | |
| [apache\_beam/io/gcp/datastore/v1new/datastoreio.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9kYXRhc3RvcmVpby5weQ==) | `33.78% <0.00%> (ø)` | |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svYmlncXVlcnlfdG9ybmFkb2VzLnB5) | `40.00% <0.00%> (ø)` | |
| [apache\_beam/examples/complete/autocomplete\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvYXV0b2NvbXBsZXRlX3Rlc3QucHk=) | `60.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_job\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjJfdXJucy5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [721 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-683920797
It seems that you need to close then open the PR to trigger `Python tests / Python Unit Tests (macos-latest, 3.6, py36) (pull_request)`.
But I find the test fails all the time for my other PRs. Let's add a committer and see if they can help us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.18% +0.85%
==========================================
Files 694 1421 +727
Lines 82230 169311 +87081
Branches 9295 9249 -46
==========================================
+ Hits 28228 59569 +31341
- Misses 53579 109319 +55740
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (ø)` | |
| [...\_beam/runners/interactive/interactive\_beam\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtX3Rlc3QucHk=) | `34.34% <0.00%> (ø)` | |
| [apache\_beam/runners/direct/bundle\_factory.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvYnVuZGxlX2ZhY3RvcnkucHk=) | `41.93% <0.00%> (ø)` | |
| [apache\_beam/io/external/xlang\_kafkaio\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwveGxhbmdfa2Fma2Fpb19pdF90ZXN0LnB5) | `42.57% <0.00%> (ø)` | |
| [...amples/snippets/transforms/elementwise/map\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9tYXBfdGVzdC5weQ==) | `61.76% <0.00%> (ø)` | |
| [...\_beam/testing/benchmarks/nexmark/queries/query6.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTYucHk=) | `0.00% <0.00%> (ø)` | |
| [.../examples/snippets/transforms/aggregation/count.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb3VudC5weQ==) | `25.00% <0.00%> (ø)` | |
| [apache\_beam/coders/observable.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vY29kZXJzL29ic2VydmFibGUucHk=) | `66.66% <0.00%> (ø)` | |
| ... and [721 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-691249975
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli closed pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli closed pull request #12686:
URL: https://github.com/apache/beam/pull/12686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-683381383
Run tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #12686:
URL: https://github.com/apache/beam/pull/12686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-681009272
> R: @KevinGG
>
> Is pipeline_analyzer safe to remove? Seems no one's referencing it since pipeline_instrument came into place.
Yes, it's safe to remove. Because we were using a different approach to decide what to cache and what to execute to resolve the re-execution/out-of-order execution issues in a REPL environment, we moved away from `pipeline_analyzer`.
>
> display_manager.py is also not referenced anymore, but I am not sure about this one since there are more recent changes to that file.
We can leave it as it is. Though we started using pipeline_graph directly, the display manager did provide a great abstraction above the underlying os and installed executable dependencies. We could extend it into doing other things in the future.
Thank you for being diligent and clean up the code base!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.21% +0.88%
==========================================
Files 694 1419 +725
Lines 82230 168800 +86570
Branches 9295 9249 -46
==========================================
+ Hits 28228 59441 +31213
- Misses 53579 108936 +55357
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `42.96% <0.00%> (ø)` | |
| [apache\_beam/utils/windowed\_value\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdXRpbHMvd2luZG93ZWRfdmFsdWVfdGVzdC5weQ==) | `41.17% <0.00%> (ø)` | |
| [apache\_beam/testing/test\_stream\_service\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlX3Rlc3QucHk=) | `33.03% <0.00%> (ø)` | |
| [apache\_beam/utils/windowed\_value.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdXRpbHMvd2luZG93ZWRfdmFsdWUucHk=) | `81.36% <0.00%> (ø)` | |
| [...snippets/transforms/aggregation/groupbykey\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9ncm91cGJ5a2V5X3Rlc3QucHk=) | `76.47% <0.00%> (ø)` | |
| [...beam/testing/benchmarks/chicago\_taxi/preprocess.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS9wcmVwcm9jZXNzLnB5) | `0.00% <0.00%> (ø)` | |
| [apache\_beam/runners/direct/direct\_metrics\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X21ldHJpY3NfdGVzdC5weQ==) | `34.42% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [719 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 35.21% +0.88%
==========================================
Files 694 1419 +725
Lines 82230 168800 +86570
Branches 9295 9249 -46
==========================================
+ Hits 28228 59441 +31213
- Misses 53579 108936 +55357
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [...nternal/clients/dataflow/dataflow\_v1b3\_messages.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L2RhdGFmbG93X3YxYjNfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/examples/cookbook/combiners\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svY29tYmluZXJzX3Rlc3QucHk=) | `50.00% <0.00%> (ø)` | |
| [apache\_beam/io/aws/clients/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/portability/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [apache\_beam/io/gcp/pubsub\_integration\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZ2NwL3B1YnN1Yl9pbnRlZ3JhdGlvbl90ZXN0LnB5) | `53.22% <0.00%> (ø)` | |
| [apache\_beam/internal/pickler\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW50ZXJuYWwvcGlja2xlcl90ZXN0LnB5) | `58.13% <0.00%> (ø)` | |
| [apache\_beam/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vX19pbml0X18ucHk=) | `80.00% <0.00%> (ø)` | |
| [apache\_beam/examples/complete/game/leader\_board.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9sZWFkZXJfYm9hcmQucHk=) | `38.77% <0.00%> (ø)` | |
| ... and [719 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-691249780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680759284
R: @KevinGG
Is pipeline_analyzer safe to remove? Seems no one's referencing it since pipeline_instrument came into place.
display_manager.py is also not referenced anymore, but I am not sure about this one since there are more recent changes to that file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
==========================================
+ Coverage 34.32% 34.38% +0.06%
==========================================
Files 694 692 -2
Lines 82230 81908 -322
Branches 9295 9249 -46
==========================================
- Hits 28228 28167 -61
+ Misses 53579 53318 -261
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-680768761
# [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=h1) Report
> Merging [#12686](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/0b364446162bdf51ad8d23b5a539e3cedbb5b936?el=desc) will **increase** coverage by `25.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12686 +/- ##
===========================================
+ Coverage 34.32% 59.52% +25.19%
===========================================
Files 694 1424 +730
Lines 82230 174728 +92498
Branches 9295 9249 -46
===========================================
+ Hits 28228 104005 +75777
- Misses 53579 70300 +16721
Partials 423 423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/interactive/pipeline\_analyzer\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplcl90ZXN0LnB5) | | |
| [runners/interactive/pipeline\_analyzer.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9hbmFseXplci5weQ==) | | |
| [apache\_beam/dataframe/frames\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lc190ZXN0LnB5) | `98.85% <0.00%> (ø)` | |
| [...ache\_beam/runners/portability/local\_job\_service.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZS5weQ==) | `81.16% <0.00%> (ø)` | |
| [...he\_beam/io/gcp/datastore/v1new/datastoreio\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9kYXRhc3RvcmVpb190ZXN0LnB5) | `98.80% <0.00%> (ø)` | |
| [...e\_beam/runners/interactive/testing/mock\_ipython.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL21vY2tfaXB5dGhvbi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV90ZXN0LnB5) | `95.12% <0.00%> (ø)` | |
| [apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `92.16% <0.00%> (ø)` | |
| [apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `74.96% <0.00%> (ø)` | |
| [.../examples/streaming\_wordcount\_debugging\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree#diff-YXBhY2hlX2JlYW0vZXhhbXBsZXMvc3RyZWFtaW5nX3dvcmRjb3VudF9kZWJ1Z2dpbmdfaXRfdGVzdC5weQ==) | `55.76% <0.00%> (ø)` | |
| ... and [724 more](https://codecov.io/gh/apache/beam/pull/12686/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=footer). Last update [0b36444...1c91142](https://codecov.io/gh/apache/beam/pull/12686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-681148629
Thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] qinyeli removed a comment on pull request #12686: Removing dead code from Interactive Beam.
Posted by GitBox <gi...@apache.org>.
qinyeli removed a comment on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-683381383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org