[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5801: Set RAW format to RBD DATADISK

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #5801:
URL: https://github.com/apache/cloudstack/pull/5801#discussion_r777312534



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -1463,7 +1463,7 @@ public Answer createVolume(final CreateObjectCommand cmd) {
             primaryPool = storagePoolMgr.getStoragePool(primaryStore.getPoolType(), primaryStore.getUuid());
             disksize = volume.getSize();
             PhysicalDiskFormat format;
-            if (volume.getFormat() == null) {
+            if (volume.getFormat() == null || StoragePoolType.RBD.equals(primaryStore.getPoolType())) {

Review comment:
       > To set the format after volume creation, check here:
   > 
   > https://github.com/apache/cloudstack/blob/b32f3697e6f98ca209bba222fa8c58112f94d85f/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java#L663
   > 
   > Irrespective of the current disk format, update to RAW when pool type is RBD.
   
   Hi @slavkap Can you check if the format can be updated here. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org