You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 16:43:19 UTC
[GitHub] [arrow] pitrou opened a new pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
pitrou opened a new pull request #9933:
URL: https://github.com/apache/arrow/pull/9933
Also use Ubuntu 20.04 by default, instead of 18.04.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-817199595
c-ares improvement: #9977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815069488
> I wonder if we can use Ubuntu's `libgrpc++-dev` package instead of building from source. As a bonus, the build would be faster...
You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815596358
@github-actions crossbow submit test-ubuntu-20.10-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9933:
URL: https://github.com/apache/arrow/pull/9933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-819500381
Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-819405392
Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20
Submitted crossbow builds: [ursacomputing/crossbow @ actions-319](https://github.com/ursacomputing/crossbow/branches/all?query=actions-319)
|Task|Status|
|----|------|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-319-azure-test-ubuntu-20.10-docs)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815594560
Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce
Submitted crossbow builds: [ursacomputing/crossbow @ actions-285](https://github.com/ursacomputing/crossbow/branches/all?query=actions-285)
|Task|Status|
|----|------|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-285-azure-test-ubuntu-20.10-docs)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815540235
OK. I'll work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-818793342
Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20
Submitted crossbow builds: [ursacomputing/crossbow @ actions-316](https://github.com/ursacomputing/crossbow/branches/all?query=actions-316)
|Task|Status|
|----|------|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-316-azure-test-ubuntu-20.10-docs)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815074016
Ok, it doesn't seem to work:
* we need a more recent libprotobuf than 20.04 provides
* our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#discussion_r609366359
##########
File path: docs/source/status.rst
##########
@@ -126,7 +126,7 @@ IPC Format
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
| Sparse tensors | ✓ | | | | | | |
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
-| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
+| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
Review comment:
It fixes the reST table markup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815831079
@github-actions crossbow submit test-ubuntu-20.10-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815063204
The Python Flight API docs still fail generating because of:
```bash
# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in <module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>>
# c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815635905
Revision: 971b6987e59235f20060e36c05e22e73216b85f9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-286](https://github.com/ursacomputing/crossbow/branches/all?query=actions-286)
|Task|Status|
|----|------|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-286-azure-test-ubuntu-20.10-docs)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815538997
That would be nice, yes :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-819293438
@github-actions crossbow submit test-ubuntu-20.10-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-816006962
Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de
Submitted crossbow builds: [ursacomputing/crossbow @ actions-297](https://github.com/ursacomputing/crossbow/branches/all?query=actions-297)
|Task|Status|
|----|------|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-297-azure-test-ubuntu-20.10-docs)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815563513
@github-actions crossbow submit test-ubuntu-20.10-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#discussion_r609411383
##########
File path: docs/source/status.rst
##########
@@ -126,7 +126,7 @@ IPC Format
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
| Sparse tensors | ✓ | | | | | | |
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
-| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
+| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
Review comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#discussion_r609170705
##########
File path: docs/source/status.rst
##########
@@ -126,7 +126,7 @@ IPC Format
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
| Sparse tensors | ✓ | | | | | | |
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
-| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
+| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
Review comment:
Do we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-816240350
Revision: 9ccb811082271fa532bb3b2556af3f021089d44b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-299](https://github.com/ursacomputing/crossbow/branches/all?query=actions-299)
|Task|Status|
|----|------|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-299-azure-test-ubuntu-20.10-docs)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815247388
https://issues.apache.org/jira/browse/ARROW-12262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815522083
> Our packages for Ubuntu 20.10 use system gRPC.
That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...
```
# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815538102
Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.
Do you want me to create a patch for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-816026681
@github-actions crossbow submit test-ubuntu-20.10-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-818646650
@github-actions crossbow submit test-ubuntu-20.10-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815068468
I wonder if we can use Ubuntu's `libgrpc++-dev` package instead of building from source. As a bonus, the build would be faster...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9933: ARROW-12262: [Doc] Enable S3 and Flight in docs build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9933:
URL: https://github.com/apache/arrow/pull/9933#issuecomment-815064288
For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org