You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/18 23:34:33 UTC

[GitHub] [commons-collections] kinow commented on a change in pull request #149: [COLLECTIONS-760]: Add tests for MapUtils

kinow commented on a change in pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
URL: https://github.com/apache/commons-collections/pull/149#discussion_r410769983
 
 

 ##########
 File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
 ##########
 @@ -56,6 +58,7 @@
  */
 @SuppressWarnings("boxing")
 public class MapUtilsTest extends AbstractAvailableLocalesTest {
+    private static final String THREE = "Three";
 
 Review comment:
   Hi @Isira-Seneviratne should we have constants for "Two", and "key"? As this is a test class, I think we can have it either way, with or without constants, as the class size is not huge as well. Up to you :+1: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services