You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/10 05:49:05 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5234: bugfix: fix error when `get_coerced_window_frame` meet `utf8`
jackwener opened a new pull request, #5234:
URL: https://github.com/apache/arrow-datafusion/pull/5234
# Which issue does this PR close?
Closes #5233.
Part of #4685
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
# Are these changes tested?
No need, current tests can cover this problem, but it was hidden by skip_failed_rules.
set `pub skip_failed_rules: bool, default = false`
Before this PR, `sort_on_window_null_string` will fail.
After this PR, they will success.
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5234: bugfix: fix error when `get_coerced_window_frame` meet `utf8`
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5234:
URL: https://github.com/apache/arrow-datafusion/pull/5234#issuecomment-1425220644
cc @HaoYang670 @liukun4515 @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5234: bugfix: fix error when `get_coerced_window_frame` meet `utf8`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5234:
URL: https://github.com/apache/arrow-datafusion/pull/5234#issuecomment-1426196971
Benchmark runs are scheduled for baseline = 0a5e8ae28d6633ba4644dbc284110c1ee5b119cc and contender = f2ce2b9b0237e5d18af7b366307e35027c99d33b. f2ce2b9b0237e5d18af7b366307e35027c99d33b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d4091b7bf8694968ab3fcac5bfee634b...9214752a18dc455a96171bb302b32509/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5dc99ce3de44073bb11f3e3397daad7...417ec12993db47bfa863d078393eba16/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8f255733d744465aaadacf46fcca7052...acaa417a5cd340c29205171923e3c3d8/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0136166714ef49eb981c7e9b91ff524b...6a5b2ee81bae4ab0863ad0d1402ff70f/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mustafasrepo commented on pull request #5234: bugfix: fix error when `get_coerced_window_frame` meet `utf8`
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on PR #5234:
URL: https://github.com/apache/arrow-datafusion/pull/5234#issuecomment-1425291337
LGTM!. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5234: bugfix: fix error when `get_coerced_window_frame` meet `utf8`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5234:
URL: https://github.com/apache/arrow-datafusion/pull/5234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org