You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Anthony Carlucci <ac...@mitre.org> on 2012/07/09 16:30:05 UTC
Re: Review Request: RAVE-683: Revamp like/dislike display
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/#review8966
-----------------------------------------------------------
Kristen, I'm unable to apply the patch in either IntelliJ or TortoiseSVN, I think because the patch contains both text and binary changes. Can you try breaking this patch up into two .patch files - one with just the text changes and one with just the binary image changes?
- Anthony Carlucci
On June 27, 2012, 6:27 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5617/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 6:27 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
>
> https://issues.apache.org/jira/browse/RAVE-683
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings-white.png 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings.png 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473
>
> Diff: https://reviews.apache.org/r/5617/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>