[GitHub] [camel-k] orpiske commented on a change in pull request #2138: fix: change prioritization of the insecure flag check to ensure it works with mixed secure/insecure registries

[GitBox <gi...@apache.org>]

orpiske commented on a change in pull request #2138:
URL: https://github.com/apache/camel-k/pull/2138#discussion_r595174634



##########
File path: pkg/trait/builder.go
##########
@@ -256,7 +256,10 @@ func (t *builderTrait) buildahTask(e *Environment) (*v1.ImageTask, error) {
 	}
 
 	var auth string
-	if e.Platform.Status.Build.Registry.Secret != "" {
+	if e.Platform.Status.Build.Registry.Insecure {

Review comment:
       Do you mean doing something like:
   
   ```if !strings.HasPrefix(image, e.Platform.Status.Build.Registry.Address) && e.Platform.Status.Build.Registry.Insecure  {
   }
   ```
   
   Such as it prioritizes it only if the registry for the image matches the registry address? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org