[GitHub] stevedlawrence opened a new pull request #27: Prepend rather than append when adding required evaluations to the root OOLAGContext

[GitBox <gi...@apache.org>]

stevedlawrence opened a new pull request #27: Prepend rather than append when adding required evaluations to the root OOLAGContext
URL: https://github.com/apache/incubator-daffodil/pull/27
 
 
   Setting the OOLAG context causes an append the required evaluations to
   the root requiredEvalFunctions list. Because it is an append, scala will
   make a copy of the requiredEvalFunctions list and append the items to
   that copy. For very large schemas with lots of Expressions (which calls
   setOOLAGContext), this can result in a huge amount of copies, resulting
   in large performance slowdowns during schema compilation. To prevent
   this, change the append to a prepend, which does not require a copy of
   the very large root requiredEvalFunctions list and will only copy the
   much smaller requiredEvalFunctions list from the child. This greatly
   reduces the copying and improves schema compilation time.
   
   DAFFODIL-1877

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services