You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/05 10:06:16 UTC

[GitHub] [dubbo] startjava opened a new issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

startjava opened a new issue #8426:
URL: https://github.com/apache/dubbo/issues/8426


   @DubboService(retries = 10)
   
   是否是bug?
   
   ---------------------------------
   
   但在消费者端使用@DubboReference(retries = 5)是正确的，一共循环6次。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] CrazyHZM closed issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
CrazyHZM closed issue #8426:
URL: https://github.com/apache/dubbo/issues/8426


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] startjava commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
startjava commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-893969021


   Dubno3.0.1
   
   
   
   发自我的iPhone
   
   
   ------------------ 原始邮件 ------------------
   发件人: 赵延 ***@***.***&gt;
   发送时间: 2021年8月6日 10:30
   收件人: apache/dubbo ***@***.***&gt;
   抄送: startjava ***@***.***&gt;, Author ***@***.***&gt;
   主题: 回复：[apache/dubbo] 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。 (#8426)
   
   
   
   
   
    
   @haoyann pls see it.
    
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] startjava commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
startjava commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-895055432


   @haoyann 代码为什么要注释掉呢？？如果这样，是不是只支持在客户端配置了，不支持在服务端配置了？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] horizonzy commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
horizonzy commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-894738472


   > retries can't be delivered, if each provider have their own retries , which one should be choosed? It should be determined by consumer instead of provider
   
   It should be delivered, consumer side pick one provide node, it can get the provider node's retry times.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] haoyann commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-894066427


   @horizonzy @startjava I will try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] startjava commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
startjava commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-899071052


   @haoyann 大佬，这个问题解决了吗？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] startjava commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
startjava commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-895768475


   文档是不是要修改一下，，不然这是误导。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] dkisser commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
dkisser commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-894072195


   retries can't be delivered, if each provider have their own retries , which one should be choosed? It should be determined by consumer instead of provider


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] CrazyHZM commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
CrazyHZM commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-954290676


   Resolved in #9147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] sunhk commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
sunhk commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-940759867


   > 
   > 
   > 文档是不是要修改一下，，不然这是误导。
   
   
   是啊，文档中竟然明确提到建议在provider端配置重试次数
   https://dubbo.apache.org/zh/docsv2.7/user/recommend/#%E5%9C%A8-provider-%E7%AB%AF%E5%B0%BD%E9%87%8F%E5%A4%9A%E9%85%8D%E7%BD%AE-consumer-%E7%AB%AF%E5%B1%9E%E6%80%A7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] startjava commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
startjava commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-895768219


   要是这么说的话，官方文档有错误啊：
   
   https://dubbo.apache.org/zh/docs/advanced/fault-tolerent-strategy/
   
   
   
   Failover Cluster
   
   失败自动切换，当出现失败，重试其它服务器。通常用于读操作，但重试会带来更长延迟。可通过&nbsp;retries="2"&nbsp;来设置重试次数(不含第一次)。
   
   重试次数配置如下：
   <dubbo:service retries="2" /&gt;
   
   
   
   
   
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人: ***@***.***&gt;; 
   发送时间: 2021年8月10日(星期二) 下午2:20
   收件人: ***@***.***&gt;; 
   抄送: ***@***.***&gt;; ***@***.***&gt;; 
   主题: Re: [apache/dubbo] 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。 (#8426)
   
   
   
   
   
      
   retries can't be delivered, if each provider have their own retries , which one should be choosed? It should be determined by consumer instead of provider
     
   It should be delivered, consumer side pick one provide node, it can get the provider node's retry times.
     
   at least it can't be deliverd in FailoverClusterInvoker，because the retries were caculated before the Invoker selected。As for others it's OK.
    
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] horizonzy commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
horizonzy commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-893956782


   @haoyann pls see it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] haoyann commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-894756680


   Because this line of code is commented out, consumer cannot merge provider parameters. Duplicate #8292.
   https://github.com/apache/dubbo/blob/321789d8131f5a3769b240c9304ea468eae48d61/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryDirectory.java#L358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] dkisser commented on issue #8426: 只在提供者端设置retries=10，值10不会传递给消费者端，最终for循环的len值是3。

Posted by GitBox <gi...@apache.org>.
dkisser commented on issue #8426:
URL: https://github.com/apache/dubbo/issues/8426#issuecomment-895760695


   > > retries can't be delivered, if each provider have their own retries , which one should be choosed? It should be determined by consumer instead of provider
   > 
   > It should be delivered, consumer side pick one provide node, it can get the provider node's retry times.
   
   at least it can't be deliverd in FailoverClusterInvoker，because the retries were caculated before the Invoker selected。As for others it's OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org