You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/17 05:03:50 UTC

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #18053: [Numpy] New FFIs for Operator: pad, prod

hzfan commented on a change in pull request #18053: [Numpy] New FFIs for Operator: pad, prod
URL: https://github.com/apache/incubator-mxnet/pull/18053#discussion_r409988276
 
 

 ##########
 File path: python/mxnet/numpy/multiarray.py
 ##########
 @@ -10363,7 +10364,154 @@ def pad(x, pad_width=None, mode="constant", **kwargs): # pylint: disable=too-man
            [10, 10, 10, 10, 10, 10, 10],
            [10, 10, 10, 10, 10, 10, 10]])
     """
-    return _mx_nd_np.pad(x, pad_width, mode, **kwargs)
+    if not _np.asarray(pad_width).dtype.kind == 'i':
 
 Review comment:
   Seems that we have checks in `_mx_nd_np.pad`? Why not simply invoke it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services