You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2015/01/27 01:55:08 UTC

svn commit: r1654923 - in /maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules: ./ multi-modules-child-nosource/src/test/java/org/apache/maven/plugins/checkstyle/its/ multi-modules-child/src/main/java/org/apache/maven/plugins/checkstyle/it...

Author: hboutemy
Date: Tue Jan 27 00:55:08 2015
New Revision: 1654923

URL: http://svn.apache.org/r1654923
Log:
fixed IT after removing maven_checks.xml from projects' svn: don't directly rely on svn

Modified:
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child-nosource/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/main/java/org/apache/maven/plugins/checkstyle/its/App.java
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/pom.xml

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child-nosource/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child-nosource/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java?rev=1654923&r1=1654922&r2=1654923&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child-nosource/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child-nosource/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java Tue Jan 27 00:55:08 2015
@@ -26,32 +26,27 @@ import junit.framework.TestSuite;
 /**
  * Unit test for simple App.
  */
-public class AppTest 
-    extends TestCase
-{
+public class AppTest extends TestCase {
     /**
      * Create the test case
      *
      * @param testName name of the test case
      */
-    public AppTest( String testName )
-    {
-        super( testName );
+    public AppTest(String testName) {
+        super(testName);
     }
 
     /**
      * @return the suite of tests being tested
      */
-    public static Test suite()
-    {
-        return new TestSuite( AppTest.class );
+    public static Test suite() {
+        return new TestSuite(AppTest.class);
     }
 
     /**
      * Rigourous Test :-)
      */
-    public void testApp()
-    {
-        assertTrue( true );
+    public void testApp() {
+        assertTrue(true);
     }
 }

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/main/java/org/apache/maven/plugins/checkstyle/its/App.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/main/java/org/apache/maven/plugins/checkstyle/its/App.java?rev=1654923&r1=1654922&r2=1654923&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/main/java/org/apache/maven/plugins/checkstyle/its/App.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/main/java/org/apache/maven/plugins/checkstyle/its/App.java Tue Jan 27 00:55:08 2015
@@ -21,12 +21,20 @@ package org.apache.maven.plugins.checkst
 
 /**
  * Hello world!
- *
  */
-public class App 
-{
-    public static void main( String[] args )
-    {
-        System.out.println( "Hello World!" );
+public final class App {
+
+    /**
+     * Hide constructor.
+     */
+    private App() {
+    }
+
+    /**
+     * Main.
+     * @param args args
+     */
+    public static void main(final String[] args) {
+        System.out.println("Hello World!");
     }
 }

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java?rev=1654923&r1=1654922&r2=1654923&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/multi-modules-child/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java Tue Jan 27 00:55:08 2015
@@ -26,32 +26,27 @@ import junit.framework.TestSuite;
 /**
  * Unit test for simple App.
  */
-public class AppTest 
-    extends TestCase
-{
+public class AppTest extends TestCase {
     /**
      * Create the test case
      *
      * @param testName name of the test case
      */
-    public AppTest( String testName )
-    {
-        super( testName );
+    public AppTest(String testName) {
+        super(testName);
     }
 
     /**
      * @return the suite of tests being tested
      */
-    public static Test suite()
-    {
-        return new TestSuite( AppTest.class );
+    public static Test suite() {
+        return new TestSuite(AppTest.class);
     }
 
     /**
      * Rigourous Test :-)
      */
-    public void testApp()
-    {
-        assertTrue( true );
+    public void testApp() {
+        assertTrue(true);
     }
 }

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/pom.xml?rev=1654923&r1=1654922&r2=1654923&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/pom.xml (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/it/multi-modules/pom.xml Tue Jan 27 00:55:08 2015
@@ -29,6 +29,7 @@
 
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+    <checkstyle.violation.ignore>JavadocPackage</checkstyle.violation.ignore>
   </properties>
 
   <build>
@@ -38,10 +39,6 @@
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>@pom.version@</version>
-          <configuration>
-            <configLocation>http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml</configLocation>
-            <headerLocation>http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven-header.txt</headerLocation>
-          </configuration>            
         </plugin>      
       </plugins>
     </pluginManagement>
@@ -51,26 +48,9 @@
         <artifactId>maven-site-plugin</artifactId>
         <version>@sitePluginVersion@</version>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>@pom.version@</version>
-      </plugin>      
     </plugins>
   </build>
 
-  <reporting>
-    <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>@pom.version@</version>
-        <configuration>
-          <configLocation>http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml</configLocation>
-        </configuration>        
-      </plugin>
-    </plugins>
-  </reporting>
   <modules>
     <module>multi-modules-child</module>
     <module>multi-modules-child-nosource</module>