You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/05/02 16:09:27 UTC
[kudu-CR] Fix building on Apple M1
Hello Alexey Serbin, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18464
to review the following change.
Change subject: Fix building on Apple M1
......................................................................
Fix building on Apple M1
gutil/atomicops-internals-macosx was written at a time when MacOS was
x86-only. aarch64-linux support was recently added to Kudu, but as this
header is used only on MacOS, this file wasn't changed. This commit
changes an ASM instruction to allow build on aarch64-macos.
Change-Id: I029a858d2da77cea84e7e6856b8a5ac02713152d
---
M src/kudu/gutil/atomicops-internals-macosx.h
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18464/1
--
To view, visit http://gerrit.cloudera.org:8080/18464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I029a858d2da77cea84e7e6856b8a5ac02713152d
Gerrit-Change-Number: 18464
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] Fix building on Apple M1
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has uploaded a new patch set (#2) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/18464 )
Change subject: Fix building on Apple M1
......................................................................
Fix building on Apple M1
Change-Id: I029a858d2da77cea84e7e6856b8a5ac02713152d
---
M src/kudu/gutil/atomicops-internals-macosx.h
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18464/2
--
To view, visit http://gerrit.cloudera.org:8080/18464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I029a858d2da77cea84e7e6856b8a5ac02713152d
Gerrit-Change-Number: 18464
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>