[GitHub] [superset] michael-s-molina commented on a change in pull request #17369: fix: Database selector overflow

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #17369:
URL: https://github.com/apache/superset/pull/17369#discussion_r744711798



##########
File path: superset-frontend/src/components/DatabaseSelector/index.tsx
##########
@@ -97,8 +107,10 @@ const SelectLabel = ({
   databaseName: string;
 }) => (
   <LabelStyle>
-    <Label>{backend}</Label>
-    {databaseName}
+    <Label className="backend">{backend}</Label>

Review comment:
       Every styled component generates a class underneath. I think this pattern is better for highly correlated components like this example, where all subcomponents are part of an atomic label. Breaking styles into multiple components for atomic units seems worse.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org