You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/11 20:28:39 UTC
[GitHub] [maven-doxia-sitetools] michael-o opened a new pull request, #47: [DOXIASITETOOLS-257] Require a skin if a site descriptor (site.xml) h…
michael-o opened a new pull request, #47:
URL: https://github.com/apache/maven-doxia-sitetools/pull/47
…as been provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #47: [DOXIASITETOOLS-257] Require a skin if a site descriptor (site.xml) h…
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #47:
URL: https://github.com/apache/maven-doxia-sitetools/pull/47#discussion_r895142915
##########
doxia-integration-tools/src/main/resources/default-site.xml:
##########
@@ -22,6 +22,11 @@ under the License.
<bannerLeft>
<name>${project.name}</name>
</bannerLeft>
+ <skin>
+ <groupId>org.apache.maven.skins</groupId>
+ <artifactId>maven-default-skin</artifactId>
+ <version>1.3</version>
+ </skin>
Review Comment:
Inheritance will kick in. Default site will only be used if upto the root parent no site descriptor has been defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] slawekjaranowski commented on a diff in pull request #47: [DOXIASITETOOLS-257] Require a skin if a site descriptor (site.xml) h…
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #47:
URL: https://github.com/apache/maven-doxia-sitetools/pull/47#discussion_r895141437
##########
doxia-integration-tools/src/main/resources/default-site.xml:
##########
@@ -22,6 +22,11 @@ under the License.
<bannerLeft>
<name>${project.name}</name>
</bannerLeft>
+ <skin>
+ <groupId>org.apache.maven.skins</groupId>
+ <artifactId>maven-default-skin</artifactId>
+ <version>1.3</version>
+ </skin>
Review Comment:
What will be the result - if project / module doesn't have site.xml but parent of project has with skin defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] asfgit merged pull request #47: [DOXIASITETOOLS-257] Require a skin if a site descriptor (site.xml) h…
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #47:
URL: https://github.com/apache/maven-doxia-sitetools/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org