You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by koushik-das <gi...@git.apache.org> on 2015/08/25 11:38:57 UTC
[GitHub] cloudstack pull request: Made following fixes in simulator
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/741
Made following fixes in simulator
- Support for ScaleVmCommand/NetworkRulesVmSecondaryIpCommand in resource layer
- Added support for scaling up a running VM in simulator
- Fixed some method names not following convention
In order to test PR https://github.com/apache/cloudstack/pull/725 using simulator some of these changes are needed.
Based on the way HV check is present in the scale VM API, had to explicitly put simulator related check to allow support. The ideal way would be to remove all these HV specific check from code and made them some configuration (by putting them in hypervisor_capabilities table in DB). But that will be a bigger effort outside the scope of this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/koushik-das/cloudstack simulator_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/741.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #741
----
commit 86684cd4bc1966ffcc4b337641fc8bf814724eb1
Author: Koushik Das <ko...@apache.org>
Date: 2015-08-25T09:22:48Z
Made following fixes in simulator
- Support for ScaleVmCommand/NetworkRulesVmSecondaryIpCommand in resource layer
- Added support for scaling up a running VM in simulator
- Fixed some method names not following convention
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135768876
@miguelaferreira your opinion feels like shackles to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/741#discussion_r37956660
--- Diff: plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java ---
@@ -449,12 +450,34 @@ public Answer CleanupNetworkRules(final CleanupNetworkRulesCmd cmd, final Simula
@Override
public Answer scaleVm(final ScaleVmCommand cmd) {
- return null; //To change body of implemented methods use File | Settings | File Templates.
+ TransactionLegacy txn = TransactionLegacy.open(TransactionLegacy.SIMULATOR_DB);
+ try {
+ txn.start();
+ final String vmName = cmd.getVmName();
+ final MockVMVO vm = _mockVmDao.findByVmName(vmName);
+ if (vm == null) {
+ return new ScaleVmAnswer(cmd, false, "Can't find VM " + vmName);
+ }
+ vm.setCpu(cmd.getCpus() * cmd.getMaxSpeed());
+ vm.setMemory(cmd.getMaxRam());
+ _mockVmDao.update(vm.getId(), vm);
+ s_logger.debug("Scaled up VM " + vmName);
+ txn.commit();
+ return new ScaleVmAnswer(cmd, true, null);
+ } catch (final Exception ex) {
+ txn.rollback();
+ throw new CloudRuntimeException("Unable to scale up VM", ex);
+ } finally {
+ txn.close();
+ txn = TransactionLegacy.open(TransactionLegacy.CLOUD_DB);
--- End diff --
Check. Thanks for the info
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135769042
@DaanHoogland I get the feeling that by this time tomorrow I might have a clue about what you meant
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134905914
Sure, I can help you.
I will write the test for this PR and then make another PR that you can merge into this one. PR of PR :) I love the github workflow!
Then, people can actually test this and say if it looks good or not with more certainly than what you get from just reading through the code. Please allow me the time to submit the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/741
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/741#discussion_r37955517
--- Diff: plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java ---
@@ -449,12 +450,34 @@ public Answer CleanupNetworkRules(final CleanupNetworkRulesCmd cmd, final Simula
@Override
public Answer scaleVm(final ScaleVmCommand cmd) {
- return null; //To change body of implemented methods use File | Settings | File Templates.
+ TransactionLegacy txn = TransactionLegacy.open(TransactionLegacy.SIMULATOR_DB);
+ try {
+ txn.start();
+ final String vmName = cmd.getVmName();
+ final MockVMVO vm = _mockVmDao.findByVmName(vmName);
+ if (vm == null) {
+ return new ScaleVmAnswer(cmd, false, "Can't find VM " + vmName);
+ }
+ vm.setCpu(cmd.getCpus() * cmd.getMaxSpeed());
+ vm.setMemory(cmd.getMaxRam());
+ _mockVmDao.update(vm.getId(), vm);
+ s_logger.debug("Scaled up VM " + vmName);
+ txn.commit();
+ return new ScaleVmAnswer(cmd, true, null);
+ } catch (final Exception ex) {
+ txn.rollback();
+ throw new CloudRuntimeException("Unable to scale up VM", ex);
+ } finally {
+ txn.close();
+ txn = TransactionLegacy.open(TransactionLegacy.CLOUD_DB);
--- End diff --
@miguelaferreira That is the current way of switching between DB's (in this case simulator and cloud). If you look at some of the other command handlers in the simulator you will see a similar pattern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134933068
Thanks @miguelaferreira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135393345
@koushik-das Then, please merge my PR (here: https://github.com/koushik-das/cloudstack/pull/1)
And then @wilderrodrigues and myself will test this PR (#741).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135739986
@wilderrodrigues can you please test this PR, it LGTM but my approval is not binding!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134875242
HI @koushik-das
I've reviewed the code in this PR and it looks pretty good. I really like what might seem like small things (lower-case on method names, extra spaces in log messages, etc). It shows attention to detail. Kudos for that.
I would like to run this somehow. Can you give me some pointers to how can I do that?
I mean, I get I need to run the simulator (although I never have before, I will learn), but then what about data center config to be deployed?
I assume that the test `smoke/test_scale_vm.py` will be the one to hit this code.
Also, if I can suggest an improvement, I would make the commit message (and the PR title along with it) more concrete. I mean, you do specify three changes in the body of the message, but the header is what we typically read in the commit history. I would re-write it as (your second bullet point): "Added support for scaling up a running VM in simulator". It seems to me like the best balance between explaining the intention of the change and not adding too much low-level details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134897494
I completely understand the reasoning behind the header text, I just don't agree that ".. following fixes .." is a good header for a commit. But given the current-state-of-the-practice in this project, it does not seem like a big deal either.
So, besides creating a scenario manually, is there a test I can run that hits this code? If there isn't wouldn't it be great to add one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/741#discussion_r37952326
--- Diff: plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java ---
@@ -449,12 +450,34 @@ public Answer CleanupNetworkRules(final CleanupNetworkRulesCmd cmd, final Simula
@Override
public Answer scaleVm(final ScaleVmCommand cmd) {
- return null; //To change body of implemented methods use File | Settings | File Templates.
+ TransactionLegacy txn = TransactionLegacy.open(TransactionLegacy.SIMULATOR_DB);
+ try {
+ txn.start();
+ final String vmName = cmd.getVmName();
+ final MockVMVO vm = _mockVmDao.findByVmName(vmName);
+ if (vm == null) {
+ return new ScaleVmAnswer(cmd, false, "Can't find VM " + vmName);
+ }
+ vm.setCpu(cmd.getCpus() * cmd.getMaxSpeed());
+ vm.setMemory(cmd.getMaxRam());
+ _mockVmDao.update(vm.getId(), vm);
+ s_logger.debug("Scaled up VM " + vmName);
+ txn.commit();
+ return new ScaleVmAnswer(cmd, true, null);
+ } catch (final Exception ex) {
+ txn.rollback();
+ throw new CloudRuntimeException("Unable to scale up VM", ex);
+ } finally {
+ txn.close();
+ txn = TransactionLegacy.open(TransactionLegacy.CLOUD_DB);
--- End diff --
Just out of curiosity: why do you open and immediately close a transaction in the `finally` block of another transaction?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135777004
@DaanHoogland I figured it was something nice, but really wasn't sure about what you meant exactly. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134895552
@miguelaferreira For running tests using simulator follow this https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes,+using+Simulator.
The tests in smoke/test_scale_vm.py needs real hardware (as there is some SSH being done to the VM created) and so cannot be run with simulator. But you can manually run a scenario where you scale up a running VM in simulator environment. About the commit message, the header does say that the commit is about simulator fixes. Since there are other changes as well, I didn't mention in the header that the commit is only about scale VM support.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134556011
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135776711
@miguelaferreira you know what ip my email lives on but to explain it to the world; your approval is very much appreciated and binding to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134901921
@miguelaferreira Sure a test can be added. Would you mind creating one and send out a PR? You can start with the smoke/test_scale_vm.py and tweak it to run only with simulator.
While working on PR #725 I had to fix the simulator to test that specific scenario (dynamic scaling with migration) and thats how I ended up fixing the simulator creating this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135740495
will test it now...
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135394707
@miguelaferreira Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135391862
Ran the test, LGTM.
test_02_scale_vm_without_hypervisor_specifics (integration.smoke.test_scale_vm.TestScaleVm) ... === TestName: test_02_scale_vm_without_hypervisor_specifics | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 44.475s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135769001
Finished the tests... LGTM :+1:
[root@cs2 cloudstack]# python -m marvin.deployDataCenter -i setup/dev/advanced.cfg
==== Log Folder Path: /tmp//MarvinLogs//DeployDataCenter__Aug_28_2015_12_57_43_0I9K5D. All logs will be available here ====
==== Deploy DC Started ====
=== Data Center Settings are dumped to /tmp//MarvinLogs//DeployDataCenter__Aug_28_2015_12_57_43_0I9K5D/dc_entries.obj===
====Deploy DC Successful=====
[root@cs2 cloudstack]# nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg \
> test/integration/smoke/test_scale_vm.py -s -a tags=advanced,required_hardware=false \
> --zone=Sandbox-simulator --hypervisor=simulator
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp//MarvinLogs//Aug_28_2015_13_01_43_5ETXDF. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_02_scale_vm_without_hypervisor_specifics | Status : SUCCESS ===
===final results are now copied to: /tmp//MarvinLogs/test_scale_vm_NP4VUD===
@bhaisaab @koushik-das @remibergsma @DaanHoogland could one of you please merge it? I'm full up to the neck right now.
Thanks for the great stuff, @miguelaferreira
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134935544
Cool! I would that that once @miguelaferreira is done with the tests and the PR of PR, we can give a 2nd LGTM and then merge it.
Thanks, Miguel!
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-136280810
Merging as 2 LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135394943
Thanks. I'm testing again with a clean environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135415998
Setup (running all unit tests)
```
git fetch upstream pull/741/head:pr/741
git checkout pr/741
mvn clean install -Pdeveloper,systemvm
mvn -Dsimulator -pl :cloud-client-ui jetty:run
```
Integration testing
```
python -m marvin.deployDataCenter -i setup/dev/advanced.cfg
nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/smoke/test_scale_vm.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp//MarvinLogs//Aug_27_2015_12_55_07_HK730O. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_02_scale_vm_without_hypervisor_specifics | Status : SUCCESS ===
===final results are now copied to: /tmp//MarvinLogs/test_scale_vm_KD77WX===
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made following fixes in simulator
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135358954
@koushik-das my PR to your PR is ready for you to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---