You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/09/29 01:26:46 UTC
[kudu-CR] thirdparty: build C dependencies with TSAN instrumentation too
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4559
to review the following change.
Change subject: thirdparty: build C dependencies with TSAN instrumentation too
......................................................................
thirdparty: build C dependencies with TSAN instrumentation too
Our C library dependencies are pretty small so this isn't a huge hit, and
it makes the sanitizer-based dependency stack much more consistent. Now,
'common' is only for tools and header-only dependencies, while
uninstrumented/tsan/... include every library.
With additional sanitization come new suppressions. I didn't spend a whole
lot of time trying to figure out which were legitimate.
Change-Id: Ie8274ff7bc57016733cdd3c26858483f74e68faf
---
M build-support/tsan-suppressions.txt
M cmake_modules/FindPmem.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
4 files changed, 144 insertions(+), 121 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/4559/1
--
To view, visit http://gerrit.cloudera.org:8080/4559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8274ff7bc57016733cdd3c26858483f74e68faf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] thirdparty: build C dependencies with TSAN instrumentation too
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: thirdparty: build C dependencies with TSAN instrumentation too
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8274ff7bc57016733cdd3c26858483f74e68faf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] thirdparty: build C dependencies with TSAN instrumentation too
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: thirdparty: build C dependencies with TSAN instrumentation too
......................................................................
thirdparty: build C dependencies with TSAN instrumentation too
Our C library dependencies are pretty small so this isn't a huge hit, and
it makes the sanitizer-based dependency stack much more consistent. Now,
'common' is only for tools and header-only dependencies, while
uninstrumented/tsan/... include every library.
With additional sanitization come new suppressions. I didn't spend a whole
lot of time trying to figure out which were legitimate.
Change-Id: Ie8274ff7bc57016733cdd3c26858483f74e68faf
Reviewed-on: http://gerrit.cloudera.org:8080/4559
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Kudu Jenkins
Tested-by: Dan Burkert <da...@cloudera.com>
---
M build-support/tsan-suppressions.txt
M cmake_modules/FindPmem.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
4 files changed, 144 insertions(+), 121 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8274ff7bc57016733cdd3c26858483f74e68faf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] thirdparty: build C dependencies with TSAN instrumentation too
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: thirdparty: build C dependencies with TSAN instrumentation too
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8274ff7bc57016733cdd3c26858483f74e68faf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No