[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5417: Updated https status code when updating CDN for a DS

[GitBox <gi...@apache.org>]

rimashah25 commented on a change in pull request #5417:
URL: https://github.com/apache/trafficcontrol/pull/5417#discussion_r556068445



##########
File path: traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
##########
@@ -171,7 +171,7 @@ <h3>Current Value</h3>
                         </div>
                         </label>
                         <div class="col-md-10 col-sm-10 col-xs-12">
-                            <select id="cdn" name="cdn" class="form-control" ng-model="deliveryService.cdnId" ng-options="cdn.id as cdn.name for cdn in cdns" required>
+                            <select id="cdn" name="cdn" class="form-control" ng-model="deliveryService.cdnId" ng-options="cdn.id as cdn.name for cdn in cdns" required ng-disabled="!settings.isNew">

Review comment:
       The reason I added it because of this statement, "_If the intent is to make CDN immutable on a DS, the cdn field of an existing DS should be disabled as well to prevent the user from changing it._"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org