You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/09/05 18:18:03 UTC

[I] Alert rule counters mix page-local and result-set-wide statistics [rocketmq-dashboard]

tju-yxq opened a new issue, #3556:
URL: https://github.com/apache/rocketmq-dashboard/issues/3556

   ## Problem\n\nThe alert rule page shows three counters in its header:\n\n- Total Rules\n- Enabled on page\n- Triggered in 24h on page\n\nTotal Rules comes from the backend page result and reflects the full filtered result set. The other two values are computed from the rows loaded for the current page. When a filter returns more rows than the current page size, the counters describe different scopes and can make alert coverage or recent activity look different from reality.\n\n## Current behavior\n\nweb/src/pages/ops/alerts.tsx computes both values from the current page only:\n\n`	s\nconst enabledCount = rules.filter((r) => r.enabled).length;\nconst triggered24h = rules.filter(/* lastTriggered within 24h */).length;\n`\n\nwhile 	otalRules is the backend total for the same filter.\n\n## Expected behavior\n\n- All counters should describe the same scope.\n- The backend should return a summary for the current filter with total, enabled, and recently triggered counts.\n- The dashboard
  should render the summary values instead of deriving two counters from the current page.\n\n## Why this matters\n\nOperators use these counters to assess alert coverage and recent activity. Mixing result-set-wide and page-local values is misleading when the rule list spans multiple pages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Alert rule counters mix page-local and result-set-wide statistics [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3556:
URL: https://github.com/apache/rocketmq-dashboard/issues/3556#issuecomment-6115559703

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Alert rule counters mix page-local and result-set-wide statistics [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #3556: Alert rule counters mix page-local and result-set-wide statistics
URL: https://github.com/apache/rocketmq-dashboard/issues/3556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Alert rule counters mix page-local and result-set-wide statistics [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #3556:
URL: https://github.com/apache/rocketmq-dashboard/issues/3556#issuecomment-5554113315

   **Issue Evaluation**
   
   Category: `bug` | Status: **Not Reproduced**
   
   After reviewing the current codebase (`alerts.tsx`), `enabledCount` and `triggered24h` are computed from the full `rules` state array (`rules.filter(...)`), not from a page-local subset. The backend returns all alert rules without pagination, and the frontend table uses `pagination={false}`.
   
   The reported issue does not apply to the current implementation. If server-side pagination is introduced, these summary counts should be provided by the API to remain accurate across pages.
   
   ---
   *Automated evaluation by @RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org