You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2021/06/20 12:44:54 UTC
[maven-dependency-analyzer] 01/01: test to demonstrate failure
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch check
in repository https://gitbox.apache.org/repos/asf/maven-dependency-analyzer.git
commit d64919454a1a68d6063c2b402f7442f11bd25de2
Author: Elliotte Rusty Harold <el...@google.com>
AuthorDate: Sun Jun 20 08:44:34 2021 -0400
test to demonstrate failure
---
.../dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java | 7 +++++--
src/test/resources/jarWithCompileDependency/project2/pom.xml | 5 +++++
.../src/main/java/jarWithCompileDependency/project2/Project2.java | 2 ++
.../java/jarWithCompileDependency/project2/Project2Test.java} | 7 ++++---
4 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java
index ffbe626..61e90d5 100644
--- a/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java
+++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java
@@ -183,10 +183,13 @@ public class DefaultProjectDependencyAnalyzerTest
}
ProjectDependencyAnalysis actualAnalysis = analyzer.analyze( project2 );
+
+ assertTrue("Incorrectly classified Guava as testonly", actualAnalysis.getTestArtifactsWithNonTestScope().isEmpty());
Artifact project1 = createArtifact( "org.apache.maven.shared.dependency-analyzer.tests",
"jarWithCompileDependency1", "jar", "1.0", "compile" );
- Set<Artifact> usedDeclaredArtifacts = Collections.singleton( project1 );
+ Artifact guava = createArtifact( "com.google.guava", "guava", "jar", "30.1.1-android", "compile" );
+ Set<Artifact> usedDeclaredArtifacts = new HashSet<>( Arrays.asList( project1, guava ) );
ProjectDependencyAnalysis expectedAnalysis = new ProjectDependencyAnalysis( usedDeclaredArtifacts, null, null,
null );
@@ -237,7 +240,7 @@ public class DefaultProjectDependencyAnalyzerTest
MavenProject project2 = getProject( "jarWithTestDependency/project2/pom.xml" );
ProjectDependencyAnalysis actualAnalysis = analyzer.analyze( project2 );
-
+
Artifact project1 = createArtifact( "org.apache.maven.shared.dependency-analyzer.tests",
"jarWithTestDependency1", "jar", "1.0", "test" );
Artifact junit = createArtifact( "junit", "junit", "jar", "3.8.1", "test" );
diff --git a/src/test/resources/jarWithCompileDependency/project2/pom.xml b/src/test/resources/jarWithCompileDependency/project2/pom.xml
index d68784a..bc920b8 100644
--- a/src/test/resources/jarWithCompileDependency/project2/pom.xml
+++ b/src/test/resources/jarWithCompileDependency/project2/pom.xml
@@ -36,6 +36,11 @@
<artifactId>jarWithCompileDependency1</artifactId>
<version>1.0</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>30.1.1-android</version>
+ </dependency>
</dependencies>
</project>
diff --git a/src/test/resources/jarWithCompileDependency/project2/src/main/java/jarWithCompileDependency/project2/Project2.java b/src/test/resources/jarWithCompileDependency/project2/src/main/java/jarWithCompileDependency/project2/Project2.java
index 5bc71ce..c634c86 100644
--- a/src/test/resources/jarWithCompileDependency/project2/src/main/java/jarWithCompileDependency/project2/Project2.java
+++ b/src/test/resources/jarWithCompileDependency/project2/src/main/java/jarWithCompileDependency/project2/Project2.java
@@ -20,6 +20,7 @@ package jarWithCompileDependency.project2;
*/
import jarWithCompileDependency.project1.Project1;
+import com.google.common.base.Strings;
/**
*
@@ -31,5 +32,6 @@ public class Project2
public Project2()
{
Project1 project = new Project1();
+ System.out.println(Strings.emptyToNull("this"));
}
}
diff --git a/src/test/resources/jarWithCompileDependency/project2/src/main/java/jarWithCompileDependency/project2/Project2.java b/src/test/resources/jarWithCompileDependency/project2/src/test/java/jarWithCompileDependency/project2/Project2Test.java
similarity index 87%
copy from src/test/resources/jarWithCompileDependency/project2/src/main/java/jarWithCompileDependency/project2/Project2.java
copy to src/test/resources/jarWithCompileDependency/project2/src/test/java/jarWithCompileDependency/project2/Project2Test.java
index 5bc71ce..a93e4f4 100644
--- a/src/test/resources/jarWithCompileDependency/project2/src/main/java/jarWithCompileDependency/project2/Project2.java
+++ b/src/test/resources/jarWithCompileDependency/project2/src/test/java/jarWithCompileDependency/project2/Project2Test.java
@@ -20,16 +20,17 @@ package jarWithCompileDependency.project2;
*/
import jarWithCompileDependency.project1.Project1;
+import com.google.common.base.Preconditions;
/**
*
*
* @author <a href="mailto:markhobson@gmail.com">Mark Hobson</a>
*/
-public class Project2
+public class Project2Test
{
- public Project2()
+ public Project2Test()
{
- Project1 project = new Project1();
+ Preconditions.checkNotNull("");
}
}