You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "William Perng (JIRA)" <ji...@apache.org> on 2008/12/18 19:39:44 UTC
[jira] Created: (OFBIZ-2092) Incorrect return amount when order is
paid by the same paymentMethodId more than one time
Incorrect return amount when order is paid by the same paymentMethodId more than one time
-----------------------------------------------------------------------------------------
Key: OFBIZ-2092
URL: https://issues.apache.org/jira/browse/OFBIZ-2092
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Environment: JDK 1.6.0_11 Windows
Reporter: William Perng
The return amount will be calculated incorrectly, if the order was paid by multiple payments with the same paymentmethodId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2092) Incorrect return amount when order
is paid by the same paymentMethodId more than one time
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657917#action_12657917 ]
Jacques Le Roux commented on OFBIZ-2092:
----------------------------------------
Ah... Something I forgot to say : "Please don't use tab but 4 spaces instead in your patches" in case of doubt read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
> Incorrect return amount when order is paid by the same paymentMethodId more than one time
> -----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2092
> URL: https://issues.apache.org/jira/browse/OFBIZ-2092
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: JDK 1.6.0_11 Windows
> Reporter: William Perng
> Assignee: Jacques Le Roux
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: patch.txt
>
>
> The return amount will be calculated incorrectly, if the order was paid by multiple payments with the same paymentmethodId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2092) Incorrect return amount when order
is paid by the same paymentMethodId more than one time
Posted by "William Perng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657850#action_12657850 ]
William Perng commented on OFBIZ-2092:
--------------------------------------
I think the problem is in "getReceivedPaymentTotalsByPaymentMethod" method of OrderReadHelper class. Because all amount values will be pushed to a map, the map value will be overwritten, if the payment method Id are the same. The fix is attached.
> Incorrect return amount when order is paid by the same paymentMethodId more than one time
> -----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2092
> URL: https://issues.apache.org/jira/browse/OFBIZ-2092
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: JDK 1.6.0_11 Windows
> Reporter: William Perng
>
> The return amount will be calculated incorrectly, if the order was paid by multiple payments with the same paymentmethodId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2092) Incorrect return amount when order is
paid by the same paymentMethodId more than one time
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2092.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 4.0
SVN trunk
Assignee: Jacques Le Roux
Thanks William,
This makes sense indeed, your patch is in trunk revision 727806, release4.0 r727807
> Incorrect return amount when order is paid by the same paymentMethodId more than one time
> -----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2092
> URL: https://issues.apache.org/jira/browse/OFBIZ-2092
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: JDK 1.6.0_11 Windows
> Reporter: William Perng
> Assignee: Jacques Le Roux
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: patch.txt
>
>
> The return amount will be calculated incorrectly, if the order was paid by multiple payments with the same paymentmethodId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2092) Incorrect return amount when order
is paid by the same paymentMethodId more than one time
Posted by "William Perng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657922#action_12657922 ]
William Perng commented on OFBIZ-2092:
--------------------------------------
sorry, my bad.
> Incorrect return amount when order is paid by the same paymentMethodId more than one time
> -----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2092
> URL: https://issues.apache.org/jira/browse/OFBIZ-2092
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: JDK 1.6.0_11 Windows
> Reporter: William Perng
> Assignee: Jacques Le Roux
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: patch.txt
>
>
> The return amount will be calculated incorrectly, if the order was paid by multiple payments with the same paymentmethodId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2092) Incorrect return amount when order is
paid by the same paymentMethodId more than one time
Posted by "William Perng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Perng updated OFBIZ-2092:
---------------------------------
Attachment: (was: patch.txt)
> Incorrect return amount when order is paid by the same paymentMethodId more than one time
> -----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2092
> URL: https://issues.apache.org/jira/browse/OFBIZ-2092
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: JDK 1.6.0_11 Windows
> Reporter: William Perng
> Attachments: patch.txt
>
>
> The return amount will be calculated incorrectly, if the order was paid by multiple payments with the same paymentmethodId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2092) Incorrect return amount when order is
paid by the same paymentMethodId more than one time
Posted by "William Perng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Perng updated OFBIZ-2092:
---------------------------------
Attachment: patch.txt
> Incorrect return amount when order is paid by the same paymentMethodId more than one time
> -----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2092
> URL: https://issues.apache.org/jira/browse/OFBIZ-2092
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: JDK 1.6.0_11 Windows
> Reporter: William Perng
> Attachments: patch.txt
>
>
> The return amount will be calculated incorrectly, if the order was paid by multiple payments with the same paymentmethodId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.