You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/07/10 05:12:41 UTC

[PR] Consolidate identifier metadata refresh tests into Core test classes [shardingsphere]

menghaoranss opened a new pull request, #39068:
URL: https://github.com/apache/shardingsphere/pull/39068

   
   Changes proposed in this pull request:
     - Consolidate identifier metadata refresh tests into Core test classes
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Consolidate identifier metadata refresh tests into Core test classes [shardingsphere]

Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.

menghaoranss commented on PR #39068:
URL: https://github.com/apache/shardingsphere/pull/39068#issuecomment-4932700657

```markdown
### Summary

**Review Result: Mergeable**

Reason: Code-scope review only; CI not reviewed by request. The PR only consolidates identifier-focused unit tests into their corresponding primary test classes, and I did not find a code-level blocker in the reviewed scope.

### Evidence

- The GitHub file list contains only test changes: removed `*IdentifierTest` classes and modified destination test classes in `infra/common` and `mode/core`.
- The deleted identifier scenarios are preserved in the destination tests for metadata/database/schema/table lookup and metadata refresh behavior.
- Focused reviewer-run verification passed:
- `./mvnw -pl infra/common -DskipITs -DskipTests=false -Dcheckstyle.skip -Dspotless.check.skip -Dtest=org.apache.shardingsphere.infra.metadata.ShardingSphereMetaDataTest,org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabaseFactoryTest,org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabaseTest,org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchemaTest,org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereTableTest test -Pcheck -T1C` exited 0.
- `./mvnw -pl mode/core -DskipITs -DskipTests=false -Dcheckstyle.skip -Dspotless.check.skip -Dtest=org.apache.shardingsphere.mode.metadata.refresher.pushdown.PushDownMetaDataRefreshEngineTest,org.apache.shardingsphere.mode.metadata.refresher.util.TableRefreshUtilsTest test -Pcheck -T1C` exited 0.
- `./mvnw -pl infra/common -DskipTests checkstyle:check -Pcheck -T1C` exited 0.
- `./mvnw -pl mode/core -DskipTests checkstyle:check -Pcheck -T1C` exited 0.

### Review Details

- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope: PR #39068 latest head `fea3157bc8e597b88dce9cb96a83a64377552a3b`, base and local merge-base `74ed32c6731878e6f1bddf6f14113b1bb7da7e14`. Reviewed the 13 files reported by GitHub `/pulls/39068/files`; the local triple-dot file list matched the GitHub file list.
- Not Reviewed Scope: Full repository build, GitHub Actions/check-runs, and unrelated modules outside the changed test files.
- Verification: Focused tests and scoped Checkstyle for the touched modules passed locally at the PR head. GitHub PR comments and review comments were checked and no public comments were present.
- Release Note / User Docs: Not required; this PR is test-only consolidation with no user-facing behavior or configuration change.
```

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Consolidate identifier metadata refresh tests into Core test classes [shardingsphere]

Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.

menghaoranss merged PR #39068:
URL: https://github.com/apache/shardingsphere/pull/39068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org