You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/10/22 19:45:37 UTC
[GitHub] [trafficcontrol] rawlinp opened a new pull request #6310: Add ability to disable TM stats polling
rawlinp opened a new pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310
For distributed traffic monitoring, we would like to disable TM stats
polling in order to reduce CPU usage and incoming bandwidth.
This PR allows TM to disable stats polling, so that it only does health polling. Similar to how TM's APIs are disabled until it has successfully _stat_ polled every cache, if stat polling is disabled, TM will disable its APIs until every cache has been successfully _health_ polled. In addition to adding a new `stat_polling` config option (default is true), this PR also adds a `distributed_polling` config option which will be implemented in a future PR.
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
<!-- **^ Add meaningful description above** --><hr>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Monitor
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Run TM with stat polling disabled (`"stat_polling": false` in traffic_monitor.cfg) while requesting its `/publish/CrStates` API every second. Observe that the API is disabled (returns a 503) until it has health polled the caches in the CDN (usually happens within 30 seconds or so, depending on the CDN).
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] TM config not currently documented <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6310: Add ability to disable TM stats polling
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310#discussion_r740478875
##########
File path: CHANGELOG.md
##########
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added a new Traffic Ops cdn.conf option -- `disable_auto_cert_deletion` -- in order to optionally prevent the automatic deletion of certificates for delivery services that no longer exist whenever a CDN snapshot is taken.
- [#6034](https://github.com/apache/trafficcontrol/issues/6034) Added new query parameter `cdn` to the `GET /api/x/deliveryserviceserver` Traffic Ops API to filter by CDN name
- Added a new Traffic Monitor configuration option -- `short_hostname_override` -- to traffic_monitor.cfg to allow overriding the system hostname that Traffic Monitor uses.
+- Added a new Traffic Monitor configuration option -- `stat_polling` (default: false) -- to traffic_monitor.cfg to disable stat polling.
Review comment:
> i think default is true right? and it is to enable stat polling?
Yes, good catch! I was thinking that the default is usually false for new options, but I specifically wanted this default to be true to avoid double negatives all over the code.
> should we add the distributed polling variable to the CHANGELOG too?
I was going to hold off on adding that one to the changelog until it's actually somewhat functional in a follow-up PR. I just figured it was easier to add both options now even though the `distributed_polling` one will be used in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 merged pull request #6310: Add ability to disable TM stats polling
Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 merged pull request #6310: Add ability to disable TM stats polling
Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 commented on pull request #6310: Add ability to disable TM stats polling
Posted by GitBox <gi...@apache.org>.
mattjackson220 commented on pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310#issuecomment-954059661
Should we add some quick notes in the docs so people know its optional for stats polling? maybe even just in `/docs/source/development/traffic_monitor.rst` just an optional label on the stats poll note?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6310: Add ability to disable TM stats polling
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310#discussion_r740478875
##########
File path: CHANGELOG.md
##########
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added a new Traffic Ops cdn.conf option -- `disable_auto_cert_deletion` -- in order to optionally prevent the automatic deletion of certificates for delivery services that no longer exist whenever a CDN snapshot is taken.
- [#6034](https://github.com/apache/trafficcontrol/issues/6034) Added new query parameter `cdn` to the `GET /api/x/deliveryserviceserver` Traffic Ops API to filter by CDN name
- Added a new Traffic Monitor configuration option -- `short_hostname_override` -- to traffic_monitor.cfg to allow overriding the system hostname that Traffic Monitor uses.
+- Added a new Traffic Monitor configuration option -- `stat_polling` (default: false) -- to traffic_monitor.cfg to disable stat polling.
Review comment:
> i think default is true right? and it is to enable stat polling?
Yes, good catch! I was thinking that the default is usually false for new options, but I specifically wanted this default to be true to avoid double negatives all over the code.
> should we add the distributed polling variable to the CHANGELOG too?
I was going to hold off on adding that one to the changelog until it's actually somewhat functional in a follow-up PR. I just figured it was easier to add both options now even though the `distributed_polling` one will be used in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #6310: Add ability to disable TM stats polling
Posted by GitBox <gi...@apache.org>.
mattjackson220 commented on a change in pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310#discussion_r735990457
##########
File path: CHANGELOG.md
##########
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added a new Traffic Ops cdn.conf option -- `disable_auto_cert_deletion` -- in order to optionally prevent the automatic deletion of certificates for delivery services that no longer exist whenever a CDN snapshot is taken.
- [#6034](https://github.com/apache/trafficcontrol/issues/6034) Added new query parameter `cdn` to the `GET /api/x/deliveryserviceserver` Traffic Ops API to filter by CDN name
- Added a new Traffic Monitor configuration option -- `short_hostname_override` -- to traffic_monitor.cfg to allow overriding the system hostname that Traffic Monitor uses.
+- Added a new Traffic Monitor configuration option -- `stat_polling` (default: false) -- to traffic_monitor.cfg to disable stat polling.
Review comment:
should we add the distributed polling variable to the CHANGELOG too?
##########
File path: CHANGELOG.md
##########
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added a new Traffic Ops cdn.conf option -- `disable_auto_cert_deletion` -- in order to optionally prevent the automatic deletion of certificates for delivery services that no longer exist whenever a CDN snapshot is taken.
- [#6034](https://github.com/apache/trafficcontrol/issues/6034) Added new query parameter `cdn` to the `GET /api/x/deliveryserviceserver` Traffic Ops API to filter by CDN name
- Added a new Traffic Monitor configuration option -- `short_hostname_override` -- to traffic_monitor.cfg to allow overriding the system hostname that Traffic Monitor uses.
+- Added a new Traffic Monitor configuration option -- `stat_polling` (default: false) -- to traffic_monitor.cfg to disable stat polling.
Review comment:
i think default is true right? and it is to enable stat polling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 merged pull request #6310: Add ability to disable TM stats polling
Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #6310:
URL: https://github.com/apache/trafficcontrol/pull/6310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org