You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Xinran Tinney <yu...@gmail.com> on 2018/07/19 19:00:38 UTC
Review Request 67975: Removed unused parameters in the documentation
of SqoopAuthBinding.java and SolrAuthBinding.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67975/
-----------------------------------------------------------
Review request for sentry and Sergio Pena.
Repository: sentry
Description
-------
Error in the documentations for SqoopAuthBinding and SolrAuthBinding
Diffs
-----
sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 32a1fc15
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java 539ccc13
Diff: https://reviews.apache.org/r/67975/diff/1/
Testing
-------
Thanks,
Xinran Tinney
Re: Review Request 67975: Removed unused parameters in the
documentation of SqoopAuthBinding.java and SolrAuthBinding.java
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67975/#review206243
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On July 19, 2018, 7 p.m., Xinran Tinney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67975/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 7 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Error in the documentations for SqoopAuthBinding and SolrAuthBinding
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 32a1fc15
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java 539ccc13
>
>
> Diff: https://reviews.apache.org/r/67975/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xinran Tinney
>
>
Re: Review Request 67975: Removed unused parameters in the
documentation of SqoopAuthBinding.java and SolrAuthBinding.java
Posted by Xinran Tinney <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67975/
-----------------------------------------------------------
(Updated July 19, 2018, 7:31 p.m.)
Review request for sentry and Sergio Pena.
Changes
-------
Added the parameter "privilege"
Repository: sentry
Description
-------
Error in the documentations for SqoopAuthBinding and SolrAuthBinding
Diffs (updated)
-----
sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 32a1fc15
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java 539ccc13
Diff: https://reviews.apache.org/r/67975/diff/2/
Changes: https://reviews.apache.org/r/67975/diff/1-2/
Testing
-------
Thanks,
Xinran Tinney
Re: Review Request 67975: Removed unused parameters in the
documentation of SqoopAuthBinding.java and SolrAuthBinding.java
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67975/#review206244
-----------------------------------------------------------
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
Lines 155-156 (original)
<https://reviews.apache.org/r/67975/#comment289148>
Can you update the java doc with privilege?
- kalyan kumar kalvagadda
On July 19, 2018, 7 p.m., Xinran Tinney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67975/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 7 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Error in the documentations for SqoopAuthBinding and SolrAuthBinding
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 32a1fc15
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java 539ccc13
>
>
> Diff: https://reviews.apache.org/r/67975/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xinran Tinney
>
>